This is an automated email from the ASF dual-hosted git repository.
lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink-table-store.git
The following commit(s) were added to refs/heads/master by this push:
new 719255d [hotfix] Update comments in FileStoreExpireImpl
719255d is described below
commit 719255da9abcbb27dd05e339447409493a3c7278
Author: JingsongLi <[email protected]>
AuthorDate: Mon Mar 7 10:56:12 2022 +0800
[hotfix] Update comments in FileStoreExpireImpl
---
.../apache/flink/table/store/file/operation/FileStoreExpireImpl.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreExpireImpl.java
b/flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreExpireImpl.java
index e6dd7e3..f4602c7 100644
---
a/flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreExpireImpl.java
+++
b/flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreExpireImpl.java
@@ -78,7 +78,9 @@ public class FileStoreExpireImpl implements FileStoreExpire {
long currentMillis = System.currentTimeMillis();
- // find earliest snapshot to retain
+ // find the earliest snapshot to retain
+ // TODO Here id will start from 1, we need to optimize the method of
finding the minimum
+ // snapshot
for (long id = Math.max(latestSnapshotId - numRetained + 1,
Snapshot.FIRST_SNAPSHOT_ID);
id <= latestSnapshotId;
id++) {
