Aitozi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r821419421
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/Observer.java
##########
@@ -129,13 +135,53 @@ private boolean observeFlinkJobStatus(FlinkDeployment
flinkApp, Configuration ef
}
}
+ public boolean observeSavepointStatus(FlinkDeployment flinkApp,
Configuration effectiveConfig) {
+ SavepointInfo savepointInfo =
flinkApp.getStatus().getJobStatus().getSavepointInfo();
+ if (savepointInfo.getTriggerId() == null) {
+ LOG.debug("Checkpointing not in progress");
+ return true;
+ }
+ SavepointFetchResult savepointFetchResult;
+ try {
+ savepointFetchResult = flinkService.fetchSavepointInfo(flinkApp,
effectiveConfig);
+ } catch (Exception e) {
+ LOG.error("Exception while fetching savepoint info", e);
+ return false;
+ }
+
+ if (!savepointFetchResult.isTriggered()) {
+ String error = savepointFetchResult.getError();
+ if (error != null
+ ||
!SavepointUtils.withinGracePeriod(operatorConfiguration, savepointInfo)) {
+ LOG.error("Savepoint not triggered, setting reconciliation
error");
Review comment:
The webhook is depend on the operator module now, we can let the webhook
to use the util in the operator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
