gyfora commented on a change in pull request #46:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/46#discussion_r821511530
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/Observer.java
##########
@@ -94,6 +96,14 @@ private void observeJmDeployment(
flinkApp.getMetadata().getNamespace(),
status);
+ List<DeploymentCondition> conditions = status.getConditions();
+ for (DeploymentCondition dc : conditions) {
+ if ("FailedCreate".equals(dc.getReason())
+ && "ReplicaFailure".equals(dc.getType())) {
+ throw new DeploymentFailedException(
+ DeploymentFailedException.COMPONENT_JOBMANAGER,
dc);
+ }
+ }
Review comment:
We should not check for new Errors if we are already in ERROR deploymant
status, otherwise it wont be possible to submit a new spec to fix the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
