wangyang0918 commented on a change in pull request #58:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/58#discussion_r826682501



##########
File path: 
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/exception/DeploymentFailedException.java
##########
@@ -26,6 +26,7 @@
 /** Exception to signal terminal deployment failure. */
 public class DeploymentFailedException extends RuntimeException {
     public static final String COMPONENT_JOBMANAGER = "JobManagerDeployment";
+    private static final long serialVersionUID = -1070179896083579221L;

Review comment:
       nit: we could always set the `serialVersionUIDs` to `1L` when introduce 
a serializable class. BTW, do we really need to serialize 
`DeploymentFailedException`?
   
   https://flink.apache.org/contributing/code-style-and-quality-java.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to