gyfora commented on a change in pull request #64:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/64#discussion_r826750620
##########
File path: helm/flink-operator/values.yaml
##########
@@ -58,7 +58,7 @@ webhook:
operatorConfiguration:
create: true
# Set append to false to replace configuration files
- # append: true
+ append: true
Review comment:
Before this change, append was the default even if not specified. That
was the source of the helm template complications :D
Now it is explicitly set to append=true in the default values.yaml but if
you omit it , it will be false.
##########
File path: helm/flink-operator/values.yaml
##########
@@ -58,7 +58,7 @@ webhook:
operatorConfiguration:
create: true
# Set append to false to replace configuration files
- # append: true
+ append: true
Review comment:
I think this is more predictable behaviour now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
