bgeng777 commented on a change in pull request #85:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/85#discussion_r830584934
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##########
@@ -114,6 +119,14 @@ public void reconcile(FlinkDeployment flinkApp, Context
context, Configuration e
}
}
+ private void restart(FlinkDeployment flinkApp, Configuration
effectiveConfig) throws Exception {
+ LOG.info("Restart application cluster now.");
+ String jobIdString = flinkApp.getStatus().getJobStatus().getJobId();
+ JobID jobID = jobIdString != null ? JobID.fromHexString(jobIdString) :
null;
+ flinkService.cancelJob(jobID, UpgradeMode.LAST_STATE, effectiveConfig);
Review comment:
IIUC, reason for using the `flinkService.cancelJob` with `LAST_STATE`
mode is to delete the cluster directly?
But in `LAST_STATE` mode, we will not delete HA config. Is that expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
