gyfora commented on pull request #44: URL: https://github.com/apache/flink-kubernetes-operator/pull/44#issuecomment-1074943957
I looked into this a bit more closely. I think the correct solution here is the following: Remove ConfigurationServiceDecorator and use `ConfigurationServiceOverrider` that does already this, you can see here (https://github.com/apache/flink-kubernetes-operator/pull/91) and here https://github.com/java-operator-sdk/java-operator-sdk/blob/v2.1.1/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java If the user specifies unbounded threadpool we override the executor service directly like you did now. If the user specifies a bounded number of threads, we only override the number of threads with withConcurrentReconciliationThreads. That will default to `Executors.newFixedThreadPool(concurrentReconciliationThreads());` which seems to work well already. Also the default number of threads currently is 5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
