wangyang0918 commented on pull request #101: URL: https://github.com/apache/flink-kubernetes-operator/pull/101#issuecomment-1076164488
> I would not rush with separating this because it's not always clear what kind of error it is. In most cases the deployment error is actually related to the reconciliation (we submitted an invalid image or service account config or something). > > I think the best thing we could do is make sure errors are cleared in a consistent way and later we can introduce new fields if we see the need. > > What do you think about this flow: > > 1. Observer observes deployment > 2. If we are not in JMDeployment.ERROR state clear the error information > 3. The reconciler will set the error again if necessery (that is how it already works) > > This might cause a back and forth setting of error states in cases where the job is running but there is an invalid reconcile request but this happens within the controller loop so the user will not see this. Nice suggestion and comments have been addressed accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
