wangyang0918 commented on a change in pull request #103:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/103#discussion_r834046231
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java
##########
@@ -93,6 +101,26 @@ public static void
updateForReconciliationError(FlinkDeployment flinkApp, String
} else {
updateControl = UpdateControl.noUpdate();
}
- return updateControl;
+
+ if (!reschedule) {
+ return updateControl;
+ }
+
+ ReconciliationStatus reconciliationStatus =
current.getStatus().getReconciliationStatus();
+ if (current.getSpec().getJob() != null
+ && current.getSpec().getJob().getState() == JobState.RUNNING
+ && reconciliationStatus != null
+ && reconciliationStatus.isSuccess()
+ &&
reconciliationStatus.getLastReconciledSpec().getJob().getState()
+ == JobState.SUSPENDED) {
+ return updateControl.rescheduleAfter(0);
Review comment:
Yes. I think we do not need to move the redeploy event to the beginning
of the queue. As a side effect, we save an unnecessary restart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
