gyfora commented on a change in pull request #106:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/106#discussion_r834144538
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/JobObserver.java
##########
@@ -81,14 +81,20 @@ private boolean observeFlinkJobStatus(
flinkAppStatus.getJobStatus().setState(JOB_STATE_UNKNOWN);
return false;
}
-
- updateJobStatus(flinkAppStatus.getJobStatus(), new
ArrayList<>(clusterJobStatuses));
- logger.info("Job status successfully updated");
+ String targetJobStatus =
+ updateJobStatus(flinkAppStatus.getJobStatus(), new
ArrayList<>(clusterJobStatuses));
+ logger.info(
+ "Job status successfully updated from {} to {}.",
Review comment:
To make this really nice we could add a branch:
```
if (changed) {
"Job status successfully updated from {} to {}."
} else {
"Job status ({state}) unchanged."
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
