Aitozi commented on a change in pull request #112:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r835746415



##########
File path: helm/flink-operator/templates/flink-operator.yaml
##########
@@ -123,6 +127,12 @@ spec:
                 path: flink-conf.yaml
               - key: log4j-console.properties
                 path: log4j-console.properties
+        {{- if .Values.hostPath.create }}
+        - name: {{ .Values.hostPath.name }}
+          hostPath:
+            path: {{ .Values.hostPath.hostPath }}
+            type: DirectoryOrCreate
+        {{- end }}

Review comment:
       What about provide two option here: hostPath and persistentvolumeclaim. 
Users can choose to mount the hostPath or persistentvolumeclaim or none ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to