Aitozi commented on a change in pull request #85:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/85#discussion_r835856230
##########
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##########
@@ -202,17 +200,19 @@ private void printCancelLogs(UpgradeMode upgradeMode) {
effectiveConfig);
}
- private void suspendJob(
+ private JobState suspendJob(
FlinkDeployment flinkApp, UpgradeMode upgradeMode, Configuration
effectiveConfig)
throws Exception {
final Optional<String> savepointOpt =
internalSuspendJob(flinkApp, upgradeMode, effectiveConfig);
JobStatus jobStatus = flinkApp.getStatus().getJobStatus();
- jobStatus.setState(JobState.SUSPENDED.name());
Review comment:
I wonder do we need to set the `JobStatus#state` to `SUSPEND` here? One
is the observed state, one is the desired state. Maybe we could just clear the
state and let the next reconcile to sync the state by observer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
