gyfora commented on a change in pull request #153:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/153#discussion_r841231326
##########
File path: docker-entrypoint.sh
##########
@@ -27,12 +27,12 @@ if [ "$1" = "help" ]; then
elif [ "$1" = "operator" ]; then
echo "Starting Operator"
- exec java -cp /$FLINK_KUBERNETES_SHADED_JAR:/$OPERATOR_JAR $LOG_CONFIG
org.apache.flink.kubernetes.operator.FlinkOperator
+ exec java $JVM_ARGS -cp /$FLINK_KUBERNETES_SHADED_JAR:/$OPERATOR_JAR
$LOG_CONFIG org.apache.flink.kubernetes.operator.FlinkOperator
Review comment:
I think we should put the JVM_ARGS after the log config, to give the
user an opportunity of overwriting every setting
##########
File path: helm/flink-kubernetes-operator/values.yaml
##########
@@ -78,3 +78,8 @@ metrics:
imagePullSecrets: []
nameOverride: ""
fullnameOverride: ""
+
+# Set the jvm start up options for webhook and operator
+jvmArgs:
+ webhook: ""
+ operator: ""
Review comment:
This looks pretty awkward. We should start structuring the helm options
a bit more.
I will probably open a ticket for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
