This is an automated email from the ASF dual-hosted git repository.
mapohl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push:
new 0e612856772 [hotfix][table][test] Remove unused private methods
(#21103)
0e612856772 is described below
commit 0e612856772d5f469c7d4a4fff90a58b6e0f5578
Author: Sergey Nuyanzin <[email protected]>
AuthorDate: Tue Oct 25 10:28:55 2022 +0200
[hotfix][table][test] Remove unused private methods (#21103)
---
.../apache/flink/table/client/cli/CliClient.java | 5 ----
.../client/gateway/local/LocalExecutorITCase.java | 32 ----------------------
2 files changed, 37 deletions(-)
diff --git
a/flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
b/flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
index d102b9426b5..9ccd9cb12a7 100644
---
a/flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
+++
b/flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
@@ -690,11 +690,6 @@ public class CliClient implements AutoCloseable {
terminal.flush();
}
- private void printWarning(String message) {
- terminal.writer().println(CliStrings.messageWarning(message).toAnsi());
- terminal.flush();
- }
-
//
--------------------------------------------------------------------------------------------
private void closeTerminal() {
diff --git
a/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
b/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
index 967cb9da21c..4746a3576bc 100644
---
a/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
+++
b/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
@@ -60,7 +60,6 @@ import org.junit.jupiter.api.extension.RegisterExtension;
import org.junit.jupiter.api.io.TempDir;
import java.io.File;
-import java.io.IOException;
import java.net.URL;
import java.util.ArrayList;
import java.util.Arrays;
@@ -80,7 +79,6 @@ import static
org.apache.flink.table.client.config.SqlClientOptions.EXECUTION_MA
import static
org.apache.flink.table.client.config.SqlClientOptions.EXECUTION_RESULT_MODE;
import static
org.apache.flink.table.utils.UserDefinedFunctions.GENERATED_LOWER_UDF_CLASS;
import static
org.apache.flink.table.utils.UserDefinedFunctions.GENERATED_LOWER_UDF_CODE;
-import static org.apache.flink.util.Preconditions.checkState;
import static org.assertj.core.api.Assertions.assertThat;
/** Contains basic tests for the {@link LocalExecutor}. */
@@ -466,11 +464,6 @@ class LocalExecutorITCase {
// Helper method
//
--------------------------------------------------------------------------------------------
- private TableResult executeSql(Executor executor, String sessionId, String
sql) {
- Operation operation = executor.parseStatement(sessionId, sql);
- return executor.executeOperation(sessionId, operation);
- }
-
private ResultDescriptor executeQuery(Executor executor, String sessionId,
String query) {
Operation operation = executor.parseStatement(sessionId, query);
return executor.executeQuery(sessionId, (QueryOperation) operation);
@@ -585,31 +578,6 @@ class LocalExecutorITCase {
return actualResults;
}
- private void verifySinkResult(String path) throws IOException {
- final List<String> actualResults = new ArrayList<>();
- TestBaseUtils.readAllResultLines(actualResults, path);
- final List<String> expectedResults = new ArrayList<>();
- expectedResults.add("TRUE,\"hello world\",\"2020-01-01 00:00:01\"");
- expectedResults.add("FALSE,\"hello world\",\"2020-01-01 00:00:02\"");
- expectedResults.add("FALSE,\"hello world\",\"2020-01-01 00:00:03\"");
- expectedResults.add("FALSE,\"hello world\",\"2020-01-01 00:00:04\"");
- expectedResults.add("TRUE,\"hello world\",\"2020-01-01 00:00:05\"");
- expectedResults.add("FALSE,\"hello world!!!!\",\"2020-01-01
00:00:06\"");
- TestBaseUtils.compareResultCollections(
- expectedResults, actualResults, Comparator.naturalOrder());
- }
-
- private void executeAndVerifySinkResult(
- Executor executor, String sessionId, String statement, String
resultPath)
- throws Exception {
- final TableResult tableResult = executeSql(executor, sessionId,
statement);
- checkState(tableResult.getJobClient().isPresent());
- // wait for job completion
- tableResult.await();
- // verify result
- verifySinkResult(resultPath);
- }
-
private Map<String, String> getDefaultSessionConfigMap() {
HashMap<String, String> configMap = new HashMap<>();
configMap.put(RUNTIME_MODE.key(),
RuntimeExecutionMode.STREAMING.name());