This is an automated email from the ASF dual-hosted git repository.

chesnay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new 38c6a4bb8af [FLINK-30067][conf] DelegatingConfiguration#set returns 
itself
38c6a4bb8af is described below

commit 38c6a4bb8af37f5a05e9d57d9787f0b25334abbf
Author: Chesnay Schepler <[email protected]>
AuthorDate: Thu Nov 17 10:06:32 2022 +0100

    [FLINK-30067][conf] DelegatingConfiguration#set returns itself
---
 .../apache/flink/configuration/DelegatingConfiguration.java    |  3 ++-
 .../flink/configuration/DelegatingConfigurationTest.java       | 10 ++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git 
a/flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java
 
b/flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java
index 54a3230cc3e..573e75d86d4 100644
--- 
a/flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java
+++ 
b/flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java
@@ -351,7 +351,8 @@ public final class DelegatingConfiguration extends 
Configuration {
 
     @Override
     public <T> Configuration set(ConfigOption<T> option, T value) {
-        return backingConfig.set(prefixOption(option, prefix), value);
+        backingConfig.set(prefixOption(option, prefix), value);
+        return this;
     }
 
     // 
--------------------------------------------------------------------------------------------
diff --git 
a/flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java
 
b/flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java
index 63215a171ba..bbd4692a13a 100644
--- 
a/flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java
+++ 
b/flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java
@@ -18,6 +18,7 @@
 
 package org.apache.flink.configuration;
 
+import org.assertj.core.api.Assertions;
 import org.junit.Test;
 
 import java.lang.reflect.Method;
@@ -137,4 +138,13 @@ public class DelegatingConfigurationTest {
         // Verification
         assertEquals(properties, mapProperties);
     }
+
+    @Test
+    public void testSetReturnsDelegatingConfiguration() {
+        final Configuration conf = new Configuration();
+        final DelegatingConfiguration delegatingConf = new 
DelegatingConfiguration(conf, "prefix.");
+
+        
Assertions.assertThat(delegatingConf.set(CoreOptions.DEFAULT_PARALLELISM, 1))
+                .isSameAs(delegatingConf);
+    }
 }

Reply via email to