This is an automated email from the ASF dual-hosted git repository. martijnvisser pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/flink-connector-jdbc.git
commit a679f4638c2a8cd5de0c5b716732ed5465d26472 Author: Martijn Visser <[email protected]> AuthorDate: Wed Dec 14 13:49:35 2022 +0100 [hotfix][Archunit] Add Archunit rule violations --- .../archunit-violations/0c7b60d6-a12c-432d-8a72-747cabaeb7ed | 0 .../archunit-violations/4bca2274-65a9-4a61-81ef-767d58233ea0 | 0 .../archunit-violations/596bd7eb-1ed5-4963-a56a-941766d61233 | 0 .../archunit-violations/b10c194a-0517-4744-830f-81abfb71ab18 | 2 ++ .../archunit-violations/d45c3af5-52c6-45fd-9926-75e75e77473a | 7 +++++++ .../archunit-violations/f242ee43-a122-4d2f-a291-6439cdb9029f | 0 flink-connector-jdbc/archunit-violations/stored.rules | 10 ++++++++-- 7 files changed, 17 insertions(+), 2 deletions(-) diff --git a/flink-connector-jdbc/archunit-violations/0c7b60d6-a12c-432d-8a72-747cabaeb7ed b/flink-connector-jdbc/archunit-violations/0c7b60d6-a12c-432d-8a72-747cabaeb7ed new file mode 100644 index 0000000..e69de29 diff --git a/flink-connector-jdbc/archunit-violations/4bca2274-65a9-4a61-81ef-767d58233ea0 b/flink-connector-jdbc/archunit-violations/4bca2274-65a9-4a61-81ef-767d58233ea0 new file mode 100644 index 0000000..e69de29 diff --git a/flink-connector-jdbc/archunit-violations/596bd7eb-1ed5-4963-a56a-941766d61233 b/flink-connector-jdbc/archunit-violations/596bd7eb-1ed5-4963-a56a-941766d61233 new file mode 100644 index 0000000..e69de29 diff --git a/flink-connector-jdbc/archunit-violations/b10c194a-0517-4744-830f-81abfb71ab18 b/flink-connector-jdbc/archunit-violations/b10c194a-0517-4744-830f-81abfb71ab18 new file mode 100644 index 0000000..400c942 --- /dev/null +++ b/flink-connector-jdbc/archunit-violations/b10c194a-0517-4744-830f-81abfb71ab18 @@ -0,0 +1,2 @@ +Class <org.apache.flink.connector.jdbc.internal.options.JdbcConnectorOptions> does not reside in a package 'org.apache.flink..table' in (JdbcConnectorOptions.java:0) +org.apache.flink.connector.jdbc.internal.options.JdbcConnectorOptions does not satisfy: annotated with @PublicEvolving or annotated with @Public \ No newline at end of file diff --git a/flink-connector-jdbc/archunit-violations/d45c3af5-52c6-45fd-9926-75e75e77473a b/flink-connector-jdbc/archunit-violations/d45c3af5-52c6-45fd-9926-75e75e77473a new file mode 100644 index 0000000..4f453d5 --- /dev/null +++ b/flink-connector-jdbc/archunit-violations/d45c3af5-52c6-45fd-9926-75e75e77473a @@ -0,0 +1,7 @@ +org.apache.flink.connector.jdbc.JdbcExactlyOnceOptions.builder(): Returned leaf type org.apache.flink.connector.jdbc.JdbcExactlyOnceOptions$JDBCExactlyOnceOptionsBuilder does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated +org.apache.flink.connector.jdbc.JdbcExecutionOptions.builder(): Returned leaf type org.apache.flink.connector.jdbc.JdbcExecutionOptions$Builder does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated +org.apache.flink.connector.jdbc.catalog.JdbcCatalog.getInternal(): Returned leaf type org.apache.flink.connector.jdbc.catalog.AbstractJdbcCatalog does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated +org.apache.flink.connector.jdbc.dialect.AbstractDialect.decimalPrecisionRange(): Returned leaf type org.apache.flink.connector.jdbc.dialect.AbstractDialect$Range does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated +org.apache.flink.connector.jdbc.dialect.AbstractDialect.timestampPrecisionRange(): Returned leaf type org.apache.flink.connector.jdbc.dialect.AbstractDialect$Range does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated +org.apache.flink.connector.jdbc.xa.XaSinkStateHandler.load(org.apache.flink.runtime.state.FunctionInitializationContext): Returned leaf type org.apache.flink.connector.jdbc.xa.JdbcXaSinkFunctionState does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated +org.apache.flink.connector.jdbc.xa.XaSinkStateHandler.store(org.apache.flink.connector.jdbc.xa.JdbcXaSinkFunctionState): Argument leaf type org.apache.flink.connector.jdbc.xa.JdbcXaSinkFunctionState does not satisfy: reside outside of package 'org.apache.flink..' or reside in any package ['..shaded..'] or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated \ No newline at end of file diff --git a/flink-connector-jdbc/archunit-violations/f242ee43-a122-4d2f-a291-6439cdb9029f b/flink-connector-jdbc/archunit-violations/f242ee43-a122-4d2f-a291-6439cdb9029f new file mode 100644 index 0000000..e69de29 diff --git a/flink-connector-jdbc/archunit-violations/stored.rules b/flink-connector-jdbc/archunit-violations/stored.rules index ee4778c..b471f5b 100644 --- a/flink-connector-jdbc/archunit-violations/stored.rules +++ b/flink-connector-jdbc/archunit-violations/stored.rules @@ -1,4 +1,10 @@ # -#Thu Jul 28 14:21:00 CST 2022 -Tests\ inheriting\ from\ AbstractTestBase\ should\ have\ name\ ending\ with\ ITCase=0f94f11b-9bc8-445a-8be8-e7dfd8a384b0 +#Wed Dec 14 13:38:22 CET 2022 +Return\ and\ argument\ types\ of\ methods\ annotated\ with\ @Public\ must\ be\ annotated\ with\ @Public.=596bd7eb-1ed5-4963-a56a-941766d61233 +Connector\ production\ code\ must\ not\ depend\ on\ non-public\ API\ outside\ of\ connector\ packages=f242ee43-a122-4d2f-a291-6439cdb9029f ITCASE\ tests\ should\ use\ a\ MiniCluster\ resource\ or\ extension=6b9ab1b0-c14d-4667-bab5-407b81fba98b +Production\ code\ must\ not\ call\ methods\ annotated\ with\ @VisibleForTesting=4bca2274-65a9-4a61-81ef-767d58233ea0 +Tests\ inheriting\ from\ AbstractTestBase\ should\ have\ name\ ending\ with\ ITCase=0f94f11b-9bc8-445a-8be8-e7dfd8a384b0 +Options\ for\ connectors\ and\ formats\ should\ reside\ in\ a\ consistent\ package\ and\ be\ public\ API.=b10c194a-0517-4744-830f-81abfb71ab18 +Return\ and\ argument\ types\ of\ methods\ annotated\ with\ @PublicEvolving\ must\ be\ annotated\ with\ @Public(Evolving).=d45c3af5-52c6-45fd-9926-75e75e77473a +Classes\ in\ API\ packages\ should\ have\ at\ least\ one\ API\ visibility\ annotation.=0c7b60d6-a12c-432d-8a72-747cabaeb7ed
