This is an automated email from the ASF dual-hosted git repository. pnowojski pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/flink.git
commit 170641285998795dd071cbf9e75a0ee83e5d1c40 Author: Anton Kalashnikov <[email protected]> AuthorDate: Thu Jan 26 17:39:19 2023 +0100 [hotfix][runtime] Check style TaskTest fix. --- .../apache/flink/runtime/taskmanager/TaskTest.java | 26 ++++++++++++---------- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java index 8e728bb87d7..057d6f3dd49 100644 --- a/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java +++ b/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java @@ -82,11 +82,11 @@ import static org.hamcrest.CoreMatchers.containsString; import static org.hamcrest.CoreMatchers.instanceOf; import static org.hamcrest.CoreMatchers.is; import static org.hamcrest.CoreMatchers.notNullValue; +import static org.hamcrest.MatcherAssert.assertThat; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNull; -import static org.junit.Assert.assertThat; import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; import static org.mockito.ArgumentMatchers.eq; @@ -931,7 +931,7 @@ public class TaskTest extends TestLogger { } /** - * The invoke() method holds a lock (trigger awaitLatch after acquisition) and cancel cannot + * The 'invoke' method holds a lock (trigger awaitLatch after acquisition) and cancel cannot * complete because it also tries to acquire the same lock. This is resolved by the watch dog, * no fatal error. */ @@ -959,7 +959,7 @@ public class TaskTest extends TestLogger { } /** - * The invoke() method blocks infinitely, but cancel() does not block. Only resolved by a fatal + * The 'invoke' method blocks infinitely, but cancel() does not block. Only resolved by a fatal * error. */ @Test @@ -1150,7 +1150,7 @@ public class TaskTest extends TestLogger { TestCheckpointResponder testCheckpointResponder = new TestCheckpointResponder(); final Task task = createTaskBuilder() - .setInvokable(InvokableDeclingingCheckpoints.class) + .setInvokable(InvokableDecliningCheckpoints.class) .setCheckpointResponder(testCheckpointResponder) .build(Executors.directExecutor()); assertCheckpointDeclined( @@ -1167,17 +1167,17 @@ public class TaskTest extends TestLogger { assertCheckpointDeclined( task, testCheckpointResponder, - InvokableDeclingingCheckpoints.REJECTED_EXECUTION_CHECKPOINT_ID, + InvokableDecliningCheckpoints.REJECTED_EXECUTION_CHECKPOINT_ID, CheckpointFailureReason.CHECKPOINT_DECLINED_TASK_CLOSING); assertCheckpointDeclined( task, testCheckpointResponder, - InvokableDeclingingCheckpoints.THROWING_CHECKPOINT_ID, + InvokableDecliningCheckpoints.THROWING_CHECKPOINT_ID, CheckpointFailureReason.TASK_FAILURE); assertCheckpointDeclined( task, testCheckpointResponder, - InvokableDeclingingCheckpoints.TRIGGERING_FAILED_CHECKPOINT_ID, + InvokableDecliningCheckpoints.TRIGGERING_FAILED_CHECKPOINT_ID, CheckpointFailureReason.TASK_FAILURE); } finally { triggerInvokableLatch(task); @@ -1246,7 +1246,7 @@ public class TaskTest extends TestLogger { @Override public void updateTaskExecutionState(TaskExecutionState taskExecutionState) { - queue.offer(taskExecutionState); + assertTrue(queue.offer(taskExecutionState)); } private void validateListenerMessage(ExecutionState state, Task task, Throwable error) { @@ -1345,7 +1345,7 @@ public class TaskTest extends TestLogger { } @Override - public void invoke() throws Exception {} + public void invoke() {} @Override public void cleanUp(Throwable throwable) throws Exception { @@ -1381,12 +1381,12 @@ public class TaskTest extends TestLogger { } } - private static class InvokableDeclingingCheckpoints extends InvokableBlockingWithTrigger { + private static class InvokableDecliningCheckpoints extends InvokableBlockingWithTrigger { public static final int REJECTED_EXECUTION_CHECKPOINT_ID = 2; public static final int THROWING_CHECKPOINT_ID = 3; public static final int TRIGGERING_FAILED_CHECKPOINT_ID = 4; - public InvokableDeclingingCheckpoints(Environment environment) { + public InvokableDecliningCheckpoints(Environment environment) { super(environment); } @@ -1421,6 +1421,7 @@ public class TaskTest extends TestLogger { // block forever synchronized (this) { + //noinspection InfiniteLoopStatement while (true) { wait(); } @@ -1439,6 +1440,7 @@ public class TaskTest extends TestLogger { // block forever synchronized (this) { + //noinspection InfiniteLoopStatement while (true) { wait(); } @@ -1446,7 +1448,7 @@ public class TaskTest extends TestLogger { } @Override - public void invoke() throws Exception {} + public void invoke() {} @Override public void cleanUp(Throwable throwable) throws Exception {
