This is an automated email from the ASF dual-hosted git repository.
lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink-table-store.git
The following commit(s) were added to refs/heads/master by this push:
new ea097d4e [hotfix] Remove ignoreEmptyCommit in StreamTableCommit
ea097d4e is described below
commit ea097d4eeeba61a743d22daa5473880e2e0de981
Author: Jingsong Lee <[email protected]>
AuthorDate: Fri Mar 3 13:30:40 2023 +0800
[hotfix] Remove ignoreEmptyCommit in StreamTableCommit
This closes #574
---
.../apache/flink/table/store/table/sink/InnerTableCommit.java | 11 +++++++++++
.../flink/table/store/table/sink/StreamTableCommit.java | 9 ---------
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git
a/flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/InnerTableCommit.java
b/flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/InnerTableCommit.java
index 82279e13..e9a79282 100644
---
a/flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/InnerTableCommit.java
+++
b/flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/InnerTableCommit.java
@@ -39,6 +39,17 @@ public interface InnerTableCommit extends StreamTableCommit,
BatchTableCommit {
InnerTableCommit withOverwrite(@Nullable List<Map<String, String>>
overwritePartitions);
+ /**
+ * If this is set to true, when there is no new data, no snapshot will be
generated. By default,
+ * empty commit is be ignored.
+ *
+ * <ul>
+ * <li>For Streaming: the default value of 'ignoreEmptyCommit' is false.
+ * <li>For Batch: the default value of 'ignoreEmptyCommit' is true.
+ * </ul>
+ */
+ InnerTableCommit ignoreEmptyCommit(boolean ignoreEmptyCommit);
+
/** @deprecated lock should pass from table. */
@Deprecated
InnerTableCommit withLock(Lock lock);
diff --git
a/flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/StreamTableCommit.java
b/flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/StreamTableCommit.java
index d27dbb5d..fab1dc34 100644
---
a/flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/StreamTableCommit.java
+++
b/flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/StreamTableCommit.java
@@ -32,15 +32,6 @@ import java.util.Set;
@Experimental
public interface StreamTableCommit extends TableCommit {
- /**
- * If this is set to true, when there is no new data, no snapshot will be
generated. By default,
- * empty commit is not be ignored.
- *
- * <p>NOTE: It is recommended to keep 'ignoreEmptyCommit' to false in
streaming write, in order
- * to better remove duplicate commits (See {@link #filterCommitted}).
- */
- StreamTableCommit ignoreEmptyCommit(boolean ignoreEmptyCommit);
-
/**
* Filter committed commits. Return uncommitted identifiers. This method
is used for failover
* cases.
