This is an automated email from the ASF dual-hosted git repository. fanrui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/flink.git
commit d237ed64476b48c78b494b0fbd6d5888785d0e55 Author: 1996fanrui <[email protected]> AuthorDate: Thu Oct 26 15:08:38 2023 +0800 [FLINK-33354][runtime][refactor] serializedJobInformation and taskInfo are never null --- .../apache/flink/runtime/deployment/TaskDeploymentDescriptor.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java b/flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java index 5985801a5f2..97596e1ac9f 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java @@ -98,10 +98,10 @@ public final class TaskDeploymentDescriptor implements Serializable { } } - /** Serialized job information or <tt>null</tt> if offloaded. */ + /** Serialized job information if non-offloaded or <tt>PermanentBlobKey</tt> if offloaded. */ private MaybeOffloaded<JobInformation> serializedJobInformation; - /** Serialized task information or <tt>null</tt> if offloaded. */ + /** Serialized task information if non-offloaded or <tt>PermanentBlobKey</tt> if offloaded. */ private MaybeOffloaded<TaskInformation> serializedTaskInformation; /** @@ -283,10 +283,6 @@ public final class TaskDeploymentDescriptor implements Serializable { inputGate.tryLoadAndDeserializeShuffleDescriptors( blobService, jobId, shuffleDescriptorsCache); } - - // make sure that the serialized job and task information fields are filled - Preconditions.checkNotNull(serializedJobInformation); - Preconditions.checkNotNull(serializedTaskInformation); } @Override
