leonardBang commented on code in PR #2937: URL: https://github.com/apache/flink-cdc/pull/2937#discussion_r1514480625
########## flink-cdc-common/src/main/java/com/ververica/cdc/common/utils/ThreadLocalCache.java: ########## @@ -0,0 +1,86 @@ +/* + * Copyright 2023 Ververica Inc. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.ververica.cdc.common.utils; + +import org.apache.flink.annotation.Internal; + +import java.util.LinkedHashMap; +import java.util.Map; +import java.util.function.Function; + +/** + * Provides a thread local cache with a maximum cache size per thread. + * + * <p>Note: Values must not be null. + */ +@Internal +public abstract class ThreadLocalCache<K, V> { + + private static final int DEFAULT_CACHE_SIZE = 64; + + private final ThreadLocal<BoundedMap<K, V>> cache = new ThreadLocal<>(); + private final int maxSizePerThread; + + protected ThreadLocalCache() { + this(DEFAULT_CACHE_SIZE); + } + + protected ThreadLocalCache(int maxSizePerThread) { + this.maxSizePerThread = maxSizePerThread; + } + + public V get(K key) { + BoundedMap<K, V> map = cache.get(); + if (map == null) { + map = new BoundedMap<>(maxSizePerThread); + cache.set(map); + } + V value = map.get(key); + if (value == null) { + value = getNewInstance(key); + map.put(key, value); + } + return value; + } + + public abstract V getNewInstance(K key); + + private static class BoundedMap<K, V> extends LinkedHashMap<K, V> { + + private static final long serialVersionUID = -211630219014422361L; Review Comment: 1L ########## flink-cdc-common/src/main/java/com/ververica/cdc/common/utils/DateTimeUtils.java: ########## @@ -0,0 +1,120 @@ +/* + * Copyright 2023 Ververica Inc. Review Comment: please rebase to fix the copyright. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
