This is an automated email from the ASF dual-hosted git repository. fcsaky pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/flink-connector-kudu.git
The following commit(s) were added to refs/heads/main by this push: new 96e8d9d [hotfix] Add `KuduSource#builder()` instead of `KuduSourceBuilder` constructor 96e8d9d is described below commit 96e8d9d2c4c6d3a745d6f8cf66df97893556f4d0 Author: Ferenc Csaky <fcs...@apache.org> AuthorDate: Thu Mar 20 16:12:22 2025 +0100 [hotfix] Add `KuduSource#builder()` instead of `KuduSourceBuilder` constructor --- .../java/org/apache/flink/connector/kudu/source/KuduSource.java | 4 ++++ .../org/apache/flink/connector/kudu/source/KuduSourceBuilder.java | 8 ++++++-- .../source/{KuduSourceTest.java => KuduSourceBuilderTest.java} | 4 ++-- .../org/apache/flink/connector/kudu/source/KuduSourceITCase.java | 4 ++-- 4 files changed, 14 insertions(+), 6 deletions(-) diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/KuduSource.java b/flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/KuduSource.java index 9e5d14b..b0eba64 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/KuduSource.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/KuduSource.java @@ -130,4 +130,8 @@ public class KuduSource<OUT> implements Source<OUT, KuduSourceSplit, KuduSourceE readerContext, rowResultConverter); } + + public static <OUT> KuduSourceBuilder<OUT> builder() { + return new KuduSourceBuilder<>(); + } } diff --git a/flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/KuduSourceBuilder.java b/flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/KuduSourceBuilder.java index 0d1eeca..7343580 100644 --- a/flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/KuduSourceBuilder.java +++ b/flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/KuduSourceBuilder.java @@ -34,10 +34,14 @@ import static org.apache.flink.util.Preconditions.checkNotNull; public class KuduSourceBuilder<OUT> { private KuduReaderConfig readerConfig; private KuduTableInfo tableInfo; - private Boundedness boundedness = Boundedness.BOUNDED; - private Duration discoveryPeriod = null; + private Boundedness boundedness; + private Duration discoveryPeriod; private RowResultConverter<OUT> rowResultConverter; + KuduSourceBuilder() { + boundedness = Boundedness.BOUNDED; + } + public KuduSourceBuilder<OUT> setTableInfo(KuduTableInfo tableInfo) { this.tableInfo = tableInfo; return this; diff --git a/flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceTest.java b/flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceBuilderTest.java similarity index 97% rename from flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceTest.java rename to flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceBuilderTest.java index aef9143..0d2d8ab 100644 --- a/flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceTest.java +++ b/flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceBuilderTest.java @@ -27,8 +27,8 @@ import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThatThrownBy; -/** Tests for {@link KuduSource}. */ -public class KuduSourceTest { +/** Tests for {@link KuduSourceBuilder}. */ +public class KuduSourceBuilderTest { @Test void testNonExistentReaderConfig() { KuduSourceBuilder<Row> builder = diff --git a/flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceITCase.java b/flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceITCase.java index 7b0c751..09402b4 100644 --- a/flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceITCase.java +++ b/flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceITCase.java @@ -67,7 +67,7 @@ public class KuduSourceITCase extends KuduSourceTestBase { throws Exception { KuduSource<Row> kuduSource = - new KuduSourceBuilder<Row>() + KuduSource.<Row>builder() .setReaderConfig(getReaderConfig()) .setTableInfo(getTableInfo()) .setRowResultConverter(new RowResultRowConverter()) @@ -92,7 +92,7 @@ public class KuduSourceITCase extends KuduSourceTestBase { public void testRecordsFromSourceBounded() throws Exception { KuduSource<Row> kuduSource = - new KuduSourceBuilder<Row>() + KuduSource.<Row>builder() .setReaderConfig(getReaderConfig()) .setTableInfo(getTableInfo()) .setRowResultConverter(new RowResultRowConverter())