This is an automated email from the ASF dual-hosted git repository.
gaborgsomogyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push:
new 2c202de5cc7 [FLINK-39642][s3] Fix Illegal argument error message
2c202de5cc7 is described below
commit 2c202de5cc7a8e5938fb103acf3fb7249ca915bd
Author: Samrat <[email protected]>
AuthorDate: Mon May 11 21:38:57 2026 +0530
[FLINK-39642][s3] Fix Illegal argument error message
---
.../org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java | 6 +++---
.../apache/flink/fs/s3native/NativeS3FileSystemFactoryTest.java | 8 +++++---
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git
a/flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java
b/flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java
index f141125b625..2e1062f7b71 100644
---
a/flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java
+++
b/flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java
@@ -356,17 +356,17 @@ public class NativeS3FileSystemFactory implements
FileSystemFactory {
// Validate part size: S3 requires minimum 5MB and maximum 5GB per part
Preconditions.checkArgument(
s3minPartSize >= S3_MULTIPART_MIN_PART_SIZE,
- "%s must be at least 5MB (5242880 bytes), but was %d bytes",
+ "%s must be at least 5MB (5242880 bytes), but was %s bytes",
PART_UPLOAD_MIN_SIZE.key(),
s3minPartSize);
Preconditions.checkArgument(
s3minPartSize <= 5L * 1024 * 1024 * 1024,
- "%s must not exceed 5GB (5368709120 bytes), but was %d bytes",
+ "%s must not exceed 5GB (5368709120 bytes), but was %s bytes",
PART_UPLOAD_MIN_SIZE.key(),
s3minPartSize);
Preconditions.checkArgument(
maxConcurrentUploads > 0,
- "%s must be positive, but was %d",
+ "%s must be positive, but was %s",
MAX_CONCURRENT_UPLOADS.key(),
maxConcurrentUploads);
diff --git
a/flink-filesystems/flink-s3-fs-native/src/test/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactoryTest.java
b/flink-filesystems/flink-s3-fs-native/src/test/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactoryTest.java
index 21d04bd09f0..82a35e3d3c4 100644
---
a/flink-filesystems/flink-s3-fs-native/src/test/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactoryTest.java
+++
b/flink-filesystems/flink-s3-fs-native/src/test/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactoryTest.java
@@ -220,7 +220,8 @@ class NativeS3FileSystemFactoryTest {
config.set(NativeS3FileSystemFactory.PART_UPLOAD_MIN_SIZE, 1024L);
assertThatThrownBy(() -> createFs(config))
.isInstanceOf(IllegalArgumentException.class)
- .hasMessageContaining("must be at least");
+ .hasMessage(
+ "s3.upload.min.part.size must be at least 5MB (5242880
bytes), but was 1024 bytes");
}
@Test
@@ -229,7 +230,8 @@ class NativeS3FileSystemFactoryTest {
config.set(NativeS3FileSystemFactory.PART_UPLOAD_MIN_SIZE, 6L * 1024 *
1024 * 1024);
assertThatThrownBy(() -> createFs(config))
.isInstanceOf(IllegalArgumentException.class)
- .hasMessageContaining("must not exceed 5GB");
+ .hasMessage(
+ "s3.upload.min.part.size must not exceed 5GB
(5368709120 bytes), but was 6442450944 bytes");
}
// --- Max concurrent uploads ---
@@ -240,7 +242,7 @@ class NativeS3FileSystemFactoryTest {
config.set(NativeS3FileSystemFactory.MAX_CONCURRENT_UPLOADS, 0);
assertThatThrownBy(() -> createFs(config))
.isInstanceOf(IllegalArgumentException.class)
- .hasMessageContaining("must be positive");
+ .hasMessage("s3.upload.max.concurrent.uploads must be
positive, but was 0");
}
// --- Entropy injection ---
