(flink-connector-elasticsearch) branch main updated: [FLINK-28109][elasticsearch] Remove dead .id(key) call in RowElasticsearchEmitter

[guoweijie]

This is an automated email from the ASF dual-hosted git repository.

reswqa pushed a commit to branch main
in repository 
https://gitbox.apache.org/repos/asf/flink-connector-elasticsearch.git


The following commit(s) were added to refs/heads/main by this push:
     new 899da17  [FLINK-28109][elasticsearch] Remove dead .id(key) call in 
RowElasticsearchEmitter
899da17 is described below

commit 899da172babc6031668e346b18a7909e2951ce4e
Author: Jayesh Lalwani <jlalw...@amazon.com>
AuthorDate: Tue Apr 28 04:18:45 2026 +0000

    [FLINK-28109][elasticsearch] Remove dead .id(key) call in 
RowElasticsearchEmitter
    
    In the else branch, key is always null (the if-condition checks
    key != null), so .id(key) is equivalent to .id(null) which is a no-op.
    Remove it to avoid confusion.
---
 .../flink/connector/elasticsearch/table/RowElasticsearchEmitter.java     | 1 -
 1 file changed, 1 deletion(-)

diff --git 
a/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/connector/elasticsearch/table/RowElasticsearchEmitter.java
 
b/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/connector/elasticsearch/table/RowElasticsearchEmitter.java
index f91aa9b..4262ac9 100644
--- 
a/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/connector/elasticsearch/table/RowElasticsearchEmitter.java
+++ 
b/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/connector/elasticsearch/table/RowElasticsearchEmitter.java
@@ -120,7 +120,6 @@ class RowElasticsearchEmitter implements 
ElasticsearchEmitter<RowData> {
         } else {
             final IndexRequest indexRequest =
                     new IndexRequest(indexGenerator.generate(row), 
documentType)
-                            .id(key)
                             .source(document, contentType);
             indexer.add(indexRequest);
         }