Updated Branches:
  refs/heads/trunk d7747cfac -> f4a5e1345

FLUME-1736: SpoolingFileLineReader must close the reader before renaming

(Hari Shreedharan via Brock Noland)


Project: http://git-wip-us.apache.org/repos/asf/flume/repo
Commit: http://git-wip-us.apache.org/repos/asf/flume/commit/f4a5e134
Tree: http://git-wip-us.apache.org/repos/asf/flume/tree/f4a5e134
Diff: http://git-wip-us.apache.org/repos/asf/flume/diff/f4a5e134

Branch: refs/heads/trunk
Commit: f4a5e1345149cadca24598f15ddf203772b27f29
Parents: d7747cf
Author: Brock Noland <[email protected]>
Authored: Mon Nov 19 09:58:59 2012 -0600
Committer: Brock Noland <[email protected]>
Committed: Mon Nov 19 09:58:59 2012 -0600

----------------------------------------------------------------------
 .../flume/client/avro/SpoolingFileLineReader.java  |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flume/blob/f4a5e134/flume-ng-core/src/main/java/org/apache/flume/client/avro/SpoolingFileLineReader.java
----------------------------------------------------------------------
diff --git 
a/flume-ng-core/src/main/java/org/apache/flume/client/avro/SpoolingFileLineReader.java
 
b/flume-ng-core/src/main/java/org/apache/flume/client/avro/SpoolingFileLineReader.java
index b37b730..8362299 100644
--- 
a/flume-ng-core/src/main/java/org/apache/flume/client/avro/SpoolingFileLineReader.java
+++ 
b/flume-ng-core/src/main/java/org/apache/flume/client/avro/SpoolingFileLineReader.java
@@ -228,6 +228,7 @@ public class SpoolingFileLineReader implements LineReader {
     String newPath = currPath + completedSuffix;
     logger.info("Preparing to move file " + currPath + " to " + newPath);
 
+    currentFile.get().reader.close();
     File newFile = new File(currPath);
 
     // Verify that spooling assumptions hold
@@ -281,7 +282,6 @@ public class SpoolingFileLineReader implements LineReader {
         throw new FlumeException(message);
       }
     }
-    currentFile.get().reader.close();
   }
 
   /**

Reply via email to