This is an automated email from the ASF dual-hosted git repository.
jark pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fluss.git
The following commit(s) were added to refs/heads/main by this push:
new e7d92ce8a [server] Rename RPC AlterTablePropertiesRequest to
AlterTableRequest for future extensibility (#1766)
e7d92ce8a is described below
commit e7d92ce8a983d8a1d26ac125814f41c99c701ef7
Author: Yang Guo <[email protected]>
AuthorDate: Sun Oct 5 17:59:39 2025 +0800
[server] Rename RPC AlterTablePropertiesRequest to AlterTableRequest for
future extensibility (#1766)
---
.../src/main/java/org/apache/fluss/client/admin/FlussAdmin.java | 6 +++---
.../src/main/java/org/apache/fluss/rpc/gateway/AdminGateway.java | 9 ++++-----
fluss-rpc/src/main/proto/FlussApi.proto | 4 ++--
.../org/apache/fluss/server/coordinator/CoordinatorService.java | 9 ++++-----
.../org/apache/fluss/server/coordinator/TableManagerITCase.java | 6 +++---
.../apache/fluss/server/coordinator/TestCoordinatorGateway.java | 7 +++----
.../org/apache/fluss/server/testutils/RpcMessageTestUtils.java | 6 +++---
7 files changed, 22 insertions(+), 25 deletions(-)
diff --git
a/fluss-client/src/main/java/org/apache/fluss/client/admin/FlussAdmin.java
b/fluss-client/src/main/java/org/apache/fluss/client/admin/FlussAdmin.java
index 29bd9b7b8..3fba1d5f4 100644
--- a/fluss-client/src/main/java/org/apache/fluss/client/admin/FlussAdmin.java
+++ b/fluss-client/src/main/java/org/apache/fluss/client/admin/FlussAdmin.java
@@ -42,7 +42,7 @@ import org.apache.fluss.rpc.RpcClient;
import org.apache.fluss.rpc.gateway.AdminGateway;
import org.apache.fluss.rpc.gateway.AdminReadOnlyGateway;
import org.apache.fluss.rpc.gateway.TabletServerGateway;
-import org.apache.fluss.rpc.messages.AlterTablePropertiesRequest;
+import org.apache.fluss.rpc.messages.AlterTableRequest;
import org.apache.fluss.rpc.messages.CreateAclsRequest;
import org.apache.fluss.rpc.messages.CreateDatabaseRequest;
import org.apache.fluss.rpc.messages.CreateTableRequest;
@@ -243,7 +243,7 @@ public class FlussAdmin implements Admin {
public CompletableFuture<Void> alterTable(
TablePath tablePath, List<TableChange> tableChanges, boolean
ignoreIfNotExists) {
tablePath.validate();
- AlterTablePropertiesRequest request = new
AlterTablePropertiesRequest();
+ AlterTableRequest request = new AlterTableRequest();
List<PbAlterConfig> pbFlussTableChanges =
tableChanges.stream()
@@ -255,7 +255,7 @@ public class FlussAdmin implements Admin {
.setTablePath()
.setDatabaseName(tablePath.getDatabaseName())
.setTableName(tablePath.getTableName());
- return gateway.alterTableProperties(request).thenApply(r -> null);
+ return gateway.alterTable(request).thenApply(r -> null);
}
@Override
diff --git
a/fluss-rpc/src/main/java/org/apache/fluss/rpc/gateway/AdminGateway.java
b/fluss-rpc/src/main/java/org/apache/fluss/rpc/gateway/AdminGateway.java
index df88eae1d..3e2c08f94 100644
--- a/fluss-rpc/src/main/java/org/apache/fluss/rpc/gateway/AdminGateway.java
+++ b/fluss-rpc/src/main/java/org/apache/fluss/rpc/gateway/AdminGateway.java
@@ -17,8 +17,8 @@
package org.apache.fluss.rpc.gateway;
-import org.apache.fluss.rpc.messages.AlterTablePropertiesRequest;
-import org.apache.fluss.rpc.messages.AlterTablePropertiesResponse;
+import org.apache.fluss.rpc.messages.AlterTableRequest;
+import org.apache.fluss.rpc.messages.AlterTableResponse;
import org.apache.fluss.rpc.messages.CreateAclsRequest;
import org.apache.fluss.rpc.messages.CreateAclsResponse;
import org.apache.fluss.rpc.messages.CreateDatabaseRequest;
@@ -69,11 +69,10 @@ public interface AdminGateway extends AdminReadOnlyGateway {
/**
* Alter a table.
*
- * @param request the request to alter the configs of a table.
+ * @param request the request to alter a table.
*/
@RPC(api = ApiKeys.ALTER_TABLE_PROPERTIES)
- CompletableFuture<AlterTablePropertiesResponse> alterTableProperties(
- AlterTablePropertiesRequest request);
+ CompletableFuture<AlterTableResponse> alterTable(AlterTableRequest
request);
/**
* Drop a table.
diff --git a/fluss-rpc/src/main/proto/FlussApi.proto
b/fluss-rpc/src/main/proto/FlussApi.proto
index 46db51849..3ba1ab461 100644
--- a/fluss-rpc/src/main/proto/FlussApi.proto
+++ b/fluss-rpc/src/main/proto/FlussApi.proto
@@ -109,7 +109,7 @@ message CreateTableResponse {
}
// alter table request and response
-message AlterTablePropertiesRequest {
+message AlterTableRequest {
required PbTablePath table_path = 1;
required bool ignore_if_not_exists = 2;
repeated PbAlterConfig config_changes = 3;
@@ -122,7 +122,7 @@ message PbAlterConfig {
required int32 op_type = 3; // SET=0, DELETE=1, APPEND=2, SUBTRACT=3
}
-message AlterTablePropertiesResponse {
+message AlterTableResponse {
}
diff --git
a/fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorService.java
b/fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorService.java
index 47cc555d2..62bfb7c0d 100644
---
a/fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorService.java
+++
b/fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorService.java
@@ -41,8 +41,8 @@ import org.apache.fluss.metadata.TablePath;
import org.apache.fluss.rpc.gateway.CoordinatorGateway;
import org.apache.fluss.rpc.messages.AdjustIsrRequest;
import org.apache.fluss.rpc.messages.AdjustIsrResponse;
-import org.apache.fluss.rpc.messages.AlterTablePropertiesRequest;
-import org.apache.fluss.rpc.messages.AlterTablePropertiesResponse;
+import org.apache.fluss.rpc.messages.AlterTableRequest;
+import org.apache.fluss.rpc.messages.AlterTableResponse;
import org.apache.fluss.rpc.messages.CommitKvSnapshotRequest;
import org.apache.fluss.rpc.messages.CommitKvSnapshotResponse;
import org.apache.fluss.rpc.messages.CommitLakeTableSnapshotRequest;
@@ -293,8 +293,7 @@ public final class CoordinatorService extends
RpcServiceBase implements Coordina
}
@Override
- public CompletableFuture<AlterTablePropertiesResponse>
alterTableProperties(
- AlterTablePropertiesRequest request) {
+ public CompletableFuture<AlterTableResponse> alterTable(AlterTableRequest
request) {
TablePath tablePath = toTablePath(request.getTablePath());
tablePath.validate();
if (authorizer != null) {
@@ -313,7 +312,7 @@ public final class CoordinatorService extends
RpcServiceBase implements Coordina
dataLakeFormat,
lakeTableTieringManager);
- return CompletableFuture.completedFuture(new
AlterTablePropertiesResponse());
+ return CompletableFuture.completedFuture(new AlterTableResponse());
}
public static TablePropertyChanges
toTablePropertyChanges(List<TableChange> tableChanges) {
diff --git
a/fluss-server/src/test/java/org/apache/fluss/server/coordinator/TableManagerITCase.java
b/fluss-server/src/test/java/org/apache/fluss/server/coordinator/TableManagerITCase.java
index 0a45f3b71..93935e00f 100644
---
a/fluss-server/src/test/java/org/apache/fluss/server/coordinator/TableManagerITCase.java
+++
b/fluss-server/src/test/java/org/apache/fluss/server/coordinator/TableManagerITCase.java
@@ -88,7 +88,7 @@ import java.util.Set;
import java.util.stream.Collectors;
import static org.apache.fluss.config.ConfigOptions.DEFAULT_LISTENER_NAME;
-import static
org.apache.fluss.server.testutils.RpcMessageTestUtils.newAlterTablePropertiesRequest;
+import static
org.apache.fluss.server.testutils.RpcMessageTestUtils.newAlterTableRequest;
import static
org.apache.fluss.server.testutils.RpcMessageTestUtils.newCreateDatabaseRequest;
import static
org.apache.fluss.server.testutils.RpcMessageTestUtils.newCreateTableRequest;
import static
org.apache.fluss.server.testutils.RpcMessageTestUtils.newDatabaseExistsRequest;
@@ -294,8 +294,8 @@ class TableManagerITCase {
List<String> resetProperties = new ArrayList<>();
adminGateway
- .alterTableProperties(
- newAlterTablePropertiesRequest(
+ .alterTable(
+ newAlterTableRequest(
tablePath,
alterTableProperties(setProperties,
resetProperties),
false))
diff --git
a/fluss-server/src/test/java/org/apache/fluss/server/coordinator/TestCoordinatorGateway.java
b/fluss-server/src/test/java/org/apache/fluss/server/coordinator/TestCoordinatorGateway.java
index c092e318a..1b8ba4c86 100644
---
a/fluss-server/src/test/java/org/apache/fluss/server/coordinator/TestCoordinatorGateway.java
+++
b/fluss-server/src/test/java/org/apache/fluss/server/coordinator/TestCoordinatorGateway.java
@@ -23,8 +23,8 @@ import org.apache.fluss.metadata.TableBucket;
import org.apache.fluss.rpc.gateway.CoordinatorGateway;
import org.apache.fluss.rpc.messages.AdjustIsrRequest;
import org.apache.fluss.rpc.messages.AdjustIsrResponse;
-import org.apache.fluss.rpc.messages.AlterTablePropertiesRequest;
-import org.apache.fluss.rpc.messages.AlterTablePropertiesResponse;
+import org.apache.fluss.rpc.messages.AlterTableRequest;
+import org.apache.fluss.rpc.messages.AlterTableResponse;
import org.apache.fluss.rpc.messages.ApiVersionsRequest;
import org.apache.fluss.rpc.messages.ApiVersionsResponse;
import org.apache.fluss.rpc.messages.CommitKvSnapshotRequest;
@@ -142,8 +142,7 @@ public class TestCoordinatorGateway implements
CoordinatorGateway {
}
@Override
- public CompletableFuture<AlterTablePropertiesResponse>
alterTableProperties(
- AlterTablePropertiesRequest request) {
+ public CompletableFuture<AlterTableResponse> alterTable(AlterTableRequest
request) {
throw new UnsupportedOperationException();
}
diff --git
a/fluss-server/src/test/java/org/apache/fluss/server/testutils/RpcMessageTestUtils.java
b/fluss-server/src/test/java/org/apache/fluss/server/testutils/RpcMessageTestUtils.java
index d13bf401a..f88cb6fb4 100644
---
a/fluss-server/src/test/java/org/apache/fluss/server/testutils/RpcMessageTestUtils.java
+++
b/fluss-server/src/test/java/org/apache/fluss/server/testutils/RpcMessageTestUtils.java
@@ -27,7 +27,7 @@ import org.apache.fluss.record.KvRecordBatch;
import org.apache.fluss.record.MemoryLogRecords;
import org.apache.fluss.record.bytesview.MemorySegmentBytesView;
import org.apache.fluss.rpc.gateway.CoordinatorGateway;
-import org.apache.fluss.rpc.messages.AlterTablePropertiesRequest;
+import org.apache.fluss.rpc.messages.AlterTableRequest;
import org.apache.fluss.rpc.messages.CreateDatabaseRequest;
import org.apache.fluss.rpc.messages.CreatePartitionRequest;
import org.apache.fluss.rpc.messages.CreateTableRequest;
@@ -141,9 +141,9 @@ public class RpcMessageTestUtils {
return createTableRequest;
}
- public static AlterTablePropertiesRequest newAlterTablePropertiesRequest(
+ public static AlterTableRequest newAlterTableRequest(
TablePath tablePath, List<PbAlterConfig> alterConfigs, boolean
ignoreIfExists) {
- AlterTablePropertiesRequest request = new
AlterTablePropertiesRequest();
+ AlterTableRequest request = new AlterTableRequest();
request.addAllConfigChanges(alterConfigs)
.setIgnoreIfNotExists(ignoreIfExists)
.setTablePath()
