stevenschlansker commented on code in PR #2305:
URL: https://github.com/apache/fory/pull/2305#discussion_r2132921134
##########
java/fory-core/src/main/java/org/apache/fory/type/TypeUtils.java:
##########
@@ -631,9 +631,12 @@ public static boolean isBean(TypeRef<?> typeRef,
TypeResolutionContext ctx) {
// do field modifiers and getter/setter validation here, not
in getDescriptors.
// If Modifier.isFinal(d.getModifiers()), use reflection
// private field that doesn't have getter/setter will be
handled by reflection.
- return ctx.getCustomTypeRegistry().hasCodec(cls,
t.getRawType())
- || isSupported(t, newTypePath)
- || isBean(t, newTypePath);
Review Comment:
This `isBean` is unreachable because `isSupported` already checks `isBean`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
