chaokunyang commented on code in PR #2312:
URL: https://github.com/apache/fory/pull/2312#discussion_r2139173361


##########
java/fory-core/src/test/java/org/apache/fory/CrossLanguageTest.java:
##########
@@ -798,4 +799,55 @@ public void testEnumField() throws java.io.IOException {
     Assert.assertEquals(xserDe(fory, a), a);
     structRoundBack(fory, a, "test_enum_field");
   }
+
+  @Test
+  public void testCodeGen() {

Review Comment:
   Could we split it into two tests, one for SCHEMA_CONSISTENT, and another for 
COMPATIBLE.
   
   And perhaps we could create a new test file `CodegenXlangTest.java` under 
`org.apache.fory.xlang` package, and move this test into that file. 
`CrossLanguageTest` is a little big currently



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to