chaokunyang commented on code in PR #2004: URL: https://github.com/apache/fory/pull/2004#discussion_r2139218765
########## csharp/Fury/Serialization/Meta/ReferenceMetaSerializer.cs: ########## @@ -0,0 +1,242 @@ +using System.Collections.Generic; +using System.Diagnostics; +using System.Diagnostics.CodeAnalysis; +using System.Threading; +using System.Threading.Tasks; +using Fury.Collections; +using Fury.Context; +using Fury.Meta; + +namespace Fury.Serialization.Meta; + +internal sealed class ReferenceMetaSerializer Review Comment: Could we keep consistent name as java/python? For example, we could name it RefResolver. In this way, when having serialization error across languages, we can easily go to the implementation of another language just based on the classname in exception trace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
