stevenschlansker commented on code in PR #2338:
URL: https://github.com/apache/fory/pull/2338#discussion_r2146238694
##########
java/fory-core/src/main/java/org/apache/fory/builder/CodecBuilder.java:
##########
@@ -162,9 +162,6 @@ protected Expression tryCastIfPublic(
return expression;
}
- // left null check in sub class encode method to reduce data dependence.
- private final boolean fieldNullable = false;
Review Comment:
I don't understand how this field works. It seems to never be assigned, so
this codec builder always thinks all fields are not-null, which seems wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
