chaokunyang commented on code in PR #2357:
URL: https://github.com/apache/fory/pull/2357#discussion_r2158097094
##########
python/setup.py:
##########
@@ -43,7 +44,12 @@ class BinaryDistribution(Distribution):
def __init__(self, attrs=None):
super().__init__(attrs=attrs)
if BAZEL_BUILD_EXT:
- subprocess.check_call(["bazel", "build", "-s", "//:cp_fory_so"])
+ bazel_args = ["bazel", "build", "-s"]
+ arch = platform.machine().lower()
+ if arch in ("x86_64", "amd64"):
+ bazel_args += ["--config=x86_64"]
Review Comment:
Is this necessary? I'm not sure, but normally bazel should be able to detect
this automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
