pjfanning commented on code in PR #2399:
URL: https://github.com/apache/fory/pull/2399#discussion_r2193242473
##########
java/fory-core/src/main/java/org/apache/fory/util/ExceptionUtils.java:
##########
@@ -61,6 +61,9 @@ public static RuntimeException handleReadFailed(Fory fory,
Throwable t) {
// carry with read objects for better trouble shooting.
List<Object> objects = Arrays.asList(readObjects.objects).subList(0,
readObjects.size);
throw new DeserializationException(objects, t);
+ } else if (t instanceof Exception) {
Review Comment:
@chaokunyang I could modify this method to add an extra param that is the
class instance that deserializeJavaObject method has access to - this would
mean that I could improve the exception message by including the class name. I
could overload the existing method by having a new method that takes the extra
param and leave this version intact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
