esafak commented on code in PR #2406:
URL: https://github.com/apache/fory/pull/2406#discussion_r2205238188
##########
.github/workflows/ci.yml:
##########
@@ -94,13 +92,11 @@ jobs:
with:
python-version: 3.8
- name: Install bazel
- run: ./ci/run_ci.sh install_bazel
- - name: Install python
- run: ./ci/run_ci.sh install_python
- - name: Install pyfory
- run: ./ci/run_ci.sh install_pyfory
+ run: python ./ci/run_ci.py cpp --install-deps-only
+ - name: Install python dependencies
+ run: pip install pyarrow==15.0.0 Cython wheel pytest setuptools -U
Review Comment:
I agree. I think there might be some redundancy here since we also do
```python
def install_cpp_deps():
"""Install dependencies for C++ development."""
# Check the Python version and install the appropriate pyarrow version
python_version = platform.python_version()
if python_version.startswith("3.13"):
exec_cmd("pip install pyarrow==18.0.0")
exec_cmd("pip install numpy")
else:
exec_cmd(f"pip install pyarrow=={PYARROW_VERSION}")
# Automatically install numpy
exec_cmd("pip install psutil")
install_bazel()
```
https://github.com/esafak/fory/blob/101f085198fabcc1abcbda1c2697034ce9d4f6cd/ci/tasks/common.py#L168-L179
I should probably let the GHA run `pip install -U pytest setuptools wheel
cython` and install arrow/numpy in python. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
