lzaeh opened a new pull request, #2427: URL: https://github.com/apache/fory/pull/2427
<!-- **Thanks for contributing to Fory.** **If this is your first time opening a PR on fory, you can refer to [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).** Contribution Checklist - The **Apache Fory (incubating)** community has restrictions on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md). - Fory has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here. --> ## What does this PR do? <!-- Describe the purpose of this PR. --> This PR investigates and fixes the issue described in #2423. - In the slice serializer, the type marker should be written and read using the correct functions, instead of using typeId directly. Otherwise, struct types may lose type information during serialization. - A test case from issue #2423 has been added to the language-specific test suite. In PR #2339 , the dynamic type ID allocation mechanism was temporarily removed to improve cross-language compatibility. However, as mentioned in both that PR and this one, the following problems still remain: - If the slice in issue #2423 is replaced with an array, the issue still exists. The original case (a slice) is already fixed in this PR. - If the slice element type is changed to a concrete map type, the issue also persists. - As noted in PR #2339, arrays and slices still have potential problems that can cause issues in cross-language deserialization. I'm currently working on fixing the above issues in my spare time. Apologies for the delay. ## Related issues close #2423 <!-- Is there any related issue? Please attach here. - #xxxx0 - #xxxx1 - #xxxx2 --> ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/fory/issues/new/choose) describing the need to do so and update the document if necessary. --> - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
