This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fory.git
The following commit(s) were added to refs/heads/main by this push:
new b0bc48178 chore: fix typos (#2433)
b0bc48178 is described below
commit b0bc481782792940b87a109ff42ad3332a67e0ef
Author: co63oc <[email protected]>
AuthorDate: Mon Jul 28 19:18:59 2025 +0800
chore: fix typos (#2433)
<!--
**Thanks for contributing to Fory.**
**If this is your first time opening a PR on fory, you can refer to
[CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).**
Contribution Checklist
- The **Apache Fory** community has requirements on the naming of pr
titles. You can also find instructions in
[CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).
- Fory has a strong focus on performance. If the PR you submit will have
an impact on performance, please benchmark it first and provide the
benchmark result here.
-->
## What does this PR do?
fix typos
<!-- Describe the purpose of this PR. -->
## Related issues
<!--
Is there any related issue? Please attach here.
- #xxxx0
- #xxxx1
- #xxxx2
-->
## Does this PR introduce any user-facing change?
<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/fory/issues/new/choose) describing the
need to do so and update the document if necessary.
-->
- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?
## Benchmark
<!--
When the PR has an impact on performance (if you don't know whether the
PR will have an impact on performance, you can submit the PR first, and
if it will have impact on performance, the code reviewer will explain
it), be sure to attach a benchmark data here.
-->
---
cpp/fory/columnar/convert_test.cc | 2 +-
dart/packages/fory/lib/src/codegen/rules/code_rules.dart | 2 +-
dart/packages/fory/lib/src/deserialize_coordinator.dart | 2 +-
docs/guide/java_serialization_guide.md | 2 +-
go/fory/type.go | 2 +-
.../main/java/org/apache/fory/benchmark/Identity2IdMap.java | 2 +-
.../src/main/java/org/apache/fory/builder/Generated.java | 2 +-
.../src/main/java/org/apache/fory/codegen/CodeFormatter.java | 2 +-
.../src/main/java/org/apache/fory/codegen/Expression.java | 2 +-
.../main/java/org/apache/fory/collection/LongLongByteMap.java | 2 +-
.../src/main/java/org/apache/fory/collection/LongMap.java | 2 +-
.../src/main/java/org/apache/fory/memory/MemoryBuffer.java | 4 ++--
.../src/main/java/org/apache/fory/resolver/ClassResolver.java | 10 +++++-----
.../main/java/org/apache/fory/serializer/LambdaSerializer.java | 2 +-
.../src/main/java/org/apache/fory/serializer/Serializers.java | 2 +-
.../fory/serializer/NonexistentClassSerializersTest.java | 2 +-
.../fory/serializer/collection/CollectionSerializersTest.java | 2 +-
.../java/org/apache/fory/format/vectorized/ArrowWriter.java | 2 +-
javascript/benchmark/index.js | 2 +-
javascript/packages/fory/lib/gen/any.ts | 2 +-
javascript/packages/fory/lib/gen/collection.ts | 2 +-
javascript/test/fory.test.ts | 10 +++++-----
javascript/test/typemeta.test.ts | 2 +-
23 files changed, 32 insertions(+), 32 deletions(-)
diff --git a/cpp/fory/columnar/convert_test.cc
b/cpp/fory/columnar/convert_test.cc
index 82d9218c9..98fcf234c 100644
--- a/cpp/fory/columnar/convert_test.cc
+++ b/cpp/fory/columnar/convert_test.cc
@@ -81,7 +81,7 @@ arrow::Status VectorToColumnarTable(const std::vector<struct
data_row> &rows,
// Indicate the start of a new list row. This will memorise the current
// offset in the values builder.
ARROW_RETURN_NOT_OK(components_builder.Append());
- // Store the actual values. The final nullptr argument tells the underyling
+ // Store the actual values. The final nullptr argument tells the underlying
// builder that all added values are valid, i.e. non-null.
ARROW_RETURN_NOT_OK(cost_components_builder.AppendValues(
row.cost_components.data(), row.cost_components.size()));
diff --git a/dart/packages/fory/lib/src/codegen/rules/code_rules.dart
b/dart/packages/fory/lib/src/codegen/rules/code_rules.dart
index 807991fb6..21ac3c0eb 100644
--- a/dart/packages/fory/lib/src/codegen/rules/code_rules.dart
+++ b/dart/packages/fory/lib/src/codegen/rules/code_rules.dart
@@ -31,7 +31,7 @@ class CodeRules {
}
''';
- // field cant override
+ // field can't override
static const String unsupportFieldOverriding = 'Classes in the inheritance
chain cannot have members with the same name, meaning field overriding is not
supported.';
static const String circularReferenceIncapableRisk = "This class's fields
(including those from the inheritance chain) are not all basic types, so it may
have circular references. To handle this, the class must have a constructor
without required parameters, but the constructor specified by @ForyCons does
not meet this condition. If you're sure there will be no circular references,
use @ForyClass(promiseAcyclic: true).";
diff --git a/dart/packages/fory/lib/src/deserialize_coordinator.dart
b/dart/packages/fory/lib/src/deserialize_coordinator.dart
index 4304b42f5..4f9f7254f 100644
--- a/dart/packages/fory/lib/src/deserialize_coordinator.dart
+++ b/dart/packages/fory/lib/src/deserialize_coordinator.dart
@@ -80,7 +80,7 @@ class DeserializeCoordinator {
return o;
}
assert(false);
- return null; // wont reach here
+ return null; // won't reach here
}
Object? xReadRefWithSer(ByteReader br, Serializer ser, DeserializerPack
pack) {
diff --git a/docs/guide/java_serialization_guide.md
b/docs/guide/java_serialization_guide.md
index deb32f0d3..449802277 100644
--- a/docs/guide/java_serialization_guide.md
+++ b/docs/guide/java_serialization_guide.md
@@ -320,7 +320,7 @@ For collection serializer, this is a special parameter
`supportCodegenHook` need
- Recommended for most collections
- When `false`:
- - Uses interfaced-based element access and dynamic serializer dispatch for
elements, which have higer cost
+ - Uses interfaced-based element access and dynamic serializer dispatch for
elements, which have higher cost
- More flexible for custom collection types
- Required when collection has special serialization needs
- Handles complex collection implementations
diff --git a/go/fory/type.go b/go/fory/type.go
index d2dd34ed3..dad56c7e1 100644
--- a/go/fory/type.go
+++ b/go/fory/type.go
@@ -156,7 +156,7 @@ const (
DECIMAL = DECIMAL128
// Fory added type for cross-language serialization.
- // FORY_TYPE_TAG for type idendified by the tag
+ // FORY_TYPE_TAG for type identified by the tag
FORY_TYPE_TAG = 256
FORY_SET = 257
FORY_PRIMITIVE_BOOL_ARRAY = 258
diff --git
a/java/benchmark/src/main/java/org/apache/fory/benchmark/Identity2IdMap.java
b/java/benchmark/src/main/java/org/apache/fory/benchmark/Identity2IdMap.java
index fb95b5ca5..b300a9094 100644
--- a/java/benchmark/src/main/java/org/apache/fory/benchmark/Identity2IdMap.java
+++ b/java/benchmark/src/main/java/org/apache/fory/benchmark/Identity2IdMap.java
@@ -20,7 +20,7 @@ import java.util.ArrayList;
import java.util.List;
import org.apache.fory.memory.Platform;
-// Drived from
+// Derived from
//
https://github.com/RuedigerMoeller/fast-serialization/blob/e8da5591daa09452791dcd992ea4f83b20937be7/src/main/java/org/nustaq/serialization/util/FSTIdentity2IdMap.java.
// Modified to include JIT inline optimization.
public class Identity2IdMap {
diff --git
a/java/fory-core/src/main/java/org/apache/fory/builder/Generated.java
b/java/fory-core/src/main/java/org/apache/fory/builder/Generated.java
index 72f893d4e..0b2d8592b 100644
--- a/java/fory-core/src/main/java/org/apache/fory/builder/Generated.java
+++ b/java/fory-core/src/main/java/org/apache/fory/builder/Generated.java
@@ -49,7 +49,7 @@ public interface Generated {
* Register notify callback to update final field type serializers if it's
jit-able.
*
* @param serializerFieldInfos fields name and types whose field value
will be updated when jit
- * succeed fot these field types.
+ * succeed for these field types.
* @see BaseObjectCodecBuilder#getOrCreateSerializer(Class)
* @see BaseObjectCodecBuilder#genCode
*/
diff --git
a/java/fory-core/src/main/java/org/apache/fory/codegen/CodeFormatter.java
b/java/fory-core/src/main/java/org/apache/fory/codegen/CodeFormatter.java
index 62c9f95e0..41793985e 100644
--- a/java/fory-core/src/main/java/org/apache/fory/codegen/CodeFormatter.java
+++ b/java/fory-core/src/main/java/org/apache/fory/codegen/CodeFormatter.java
@@ -19,7 +19,7 @@
package org.apache.fory.codegen;
-/** Code formatter to format generated code for better readbility. */
+/** Code formatter to format generated code for better readability. */
public class CodeFormatter {
/** Format code to add line number for debug. */
diff --git
a/java/fory-core/src/main/java/org/apache/fory/codegen/Expression.java
b/java/fory-core/src/main/java/org/apache/fory/codegen/Expression.java
index 955924265..582c23612 100644
--- a/java/fory-core/src/main/java/org/apache/fory/codegen/Expression.java
+++ b/java/fory-core/src/main/java/org/apache/fory/codegen/Expression.java
@@ -2183,7 +2183,7 @@ public interface Expression {
/**
* Use lambda to create a new context, and by capturing variables, we can
make the codegen of
- * thoese variable expressions happen before while loop.
+ * those variable expressions happen before while loop.
*/
public While(Expression predicate, SerializableSupplier<Expression>
action) {
this(
diff --git
a/java/fory-core/src/main/java/org/apache/fory/collection/LongLongByteMap.java
b/java/fory-core/src/main/java/org/apache/fory/collection/LongLongByteMap.java
index dd26f7947..3df143179 100644
---
a/java/fory-core/src/main/java/org/apache/fory/collection/LongLongByteMap.java
+++
b/java/fory-core/src/main/java/org/apache/fory/collection/LongLongByteMap.java
@@ -82,7 +82,7 @@ public final class LongLongByteMap<V> {
/**
* Returns the index of the key if already present, else -(index + 1) for
the next empty index.
- * This can be overridden in this pacakge to compare for equality
differently than {@link
+ * This can be overridden in this package to compare for equality
differently than {@link
* Object#equals(Object)}.
*/
private int locateKey(long k1, long k2, byte k3) {
diff --git
a/java/fory-core/src/main/java/org/apache/fory/collection/LongMap.java
b/java/fory-core/src/main/java/org/apache/fory/collection/LongMap.java
index e4afbca71..fc4f59a8d 100644
--- a/java/fory-core/src/main/java/org/apache/fory/collection/LongMap.java
+++ b/java/fory-core/src/main/java/org/apache/fory/collection/LongMap.java
@@ -148,7 +148,7 @@ public class LongMap<V> {
/**
* Returns the index of the key if already present, else -(index + 1) for
the next empty index.
- * This can be overridden in this pacakge to compare for equality
differently than {@link
+ * This can be overridden in this package to compare for equality
differently than {@link
* Object#equals(Object)}.
*/
private int locateKey(long key) {
diff --git
a/java/fory-core/src/main/java/org/apache/fory/memory/MemoryBuffer.java
b/java/fory-core/src/main/java/org/apache/fory/memory/MemoryBuffer.java
index 4492ef995..ae35d1633 100644
--- a/java/fory-core/src/main/java/org/apache/fory/memory/MemoryBuffer.java
+++ b/java/fory-core/src/main/java/org/apache/fory/memory/MemoryBuffer.java
@@ -1654,7 +1654,7 @@ public final class MemoryBuffer {
}
}
- /** Reads the 1-5 byte as a varint on a little endian mache. */
+ /** Reads the 1-5 byte as a varint on a little endian machine. */
@CodegenInvoke
// CHECKSTYLE.OFF:MethodName
public int _readVarInt32OnLE() {
@@ -1697,7 +1697,7 @@ public final class MemoryBuffer {
return (result >>> 1) ^ -(result & 1);
}
- /** Reads the 1-5 byte as a varint on a big endian mache. */
+ /** Reads the 1-5 byte as a varint on a big endian machine. */
@CodegenInvoke
// CHECKSTYLE.OFF:MethodName
public int _readVarInt32OnBE() {
diff --git
a/java/fory-core/src/main/java/org/apache/fory/resolver/ClassResolver.java
b/java/fory-core/src/main/java/org/apache/fory/resolver/ClassResolver.java
index 42c4c5568..0e62c54d4 100644
--- a/java/fory-core/src/main/java/org/apache/fory/resolver/ClassResolver.java
+++ b/java/fory-core/src/main/java/org/apache/fory/resolver/ClassResolver.java
@@ -1478,7 +1478,7 @@ public class ClassResolver implements TypeResolver {
}
}
- // The jit-compiled native code fot this method will be too big for inline,
so we generated
+ // The jit-compiled native code for this method will be too big for inline,
so we generated
// `getClassInfo`
// in fory-jit, see `BaseSeqCodecBuilder#writeAndGetClassInfo`
// public ClassInfo writeClassInfo(MemoryBuffer buffer, Class<?> cls,
ClassInfoHolder
@@ -1767,24 +1767,24 @@ public class ClassResolver implements TypeResolver {
* <p>See `already compiled into a big method` in <a
*
href="https://wiki.openjdk.org/display/HotSpot/Server+Compiler+Inlining+Messages";>Server+Compiler+Inlining+Messages</a>
*/
- // Note: Thread safe fot jit thread to call.
+ // Note: Thread safe for jit thread to call.
public Expression writeClassExpr(
Expression classResolverRef, Expression buffer, Expression classInfo) {
return new Invoke(classResolverRef, "writeClassInfo", buffer, classInfo);
}
- // Note: Thread safe fot jit thread to call.
+ // Note: Thread safe for jit thread to call.
public Expression writeClassExpr(Expression buffer, short classId) {
Preconditions.checkArgument(classId != NO_CLASS_ID);
return writeClassExpr(buffer, Literal.ofShort(classId));
}
- // Note: Thread safe fot jit thread to call.
+ // Note: Thread safe for jit thread to call.
public Expression writeClassExpr(Expression buffer, Expression classId) {
return new Invoke(buffer, "writeVarUint32", new Expression.BitShift("<<",
classId, 1));
}
- // Note: Thread safe fot jit thread to call.
+ // Note: Thread safe for jit thread to call.
public Expression skipRegisteredClassExpr(Expression buffer) {
return new Invoke(buffer, "readVarUint32Small14");
}
diff --git
a/java/fory-core/src/main/java/org/apache/fory/serializer/LambdaSerializer.java
b/java/fory-core/src/main/java/org/apache/fory/serializer/LambdaSerializer.java
index 753ebcd60..2edfafeac 100644
---
a/java/fory-core/src/main/java/org/apache/fory/serializer/LambdaSerializer.java
+++
b/java/fory-core/src/main/java/org/apache/fory/serializer/LambdaSerializer.java
@@ -31,7 +31,7 @@ import org.apache.fory.util.Preconditions;
/**
* Serializer for java serializable lambda. Use fory to serialize java lambda
instead of JDK
- * serialization to avoid serialization captured values in closure using JDK,
which mis slow and not
+ * serialization to avoid serialization captured values in closure using JDK,
which is slow and not
* secure(will work around type white-list).
*/
@SuppressWarnings({"unchecked", "rawtypes"})
diff --git
a/java/fory-core/src/main/java/org/apache/fory/serializer/Serializers.java
b/java/fory-core/src/main/java/org/apache/fory/serializer/Serializers.java
index ad25eb7ab..ce936d740 100644
--- a/java/fory-core/src/main/java/org/apache/fory/serializer/Serializers.java
+++ b/java/fory-core/src/main/java/org/apache/fory/serializer/Serializers.java
@@ -544,7 +544,7 @@ public class Serializers {
* object is safe and used sometimes, so fory should support its
serialization without disable
* serializable or class registration checks.
*/
- // Use a separate serializer to avoid codegen for emtpy object.
+ // Use a separate serializer to avoid codegen for empty object.
public static final class EmptyObjectSerializer extends
ImmutableSerializer<Object> {
public EmptyObjectSerializer(Fory fory) {
diff --git
a/java/fory-core/src/test/java/org/apache/fory/serializer/NonexistentClassSerializersTest.java
b/java/fory-core/src/test/java/org/apache/fory/serializer/NonexistentClassSerializersTest.java
index 99b418249..c9ec51cbd 100644
---
a/java/fory-core/src/test/java/org/apache/fory/serializer/NonexistentClassSerializersTest.java
+++
b/java/fory-core/src/test/java/org/apache/fory/serializer/NonexistentClassSerializersTest.java
@@ -104,7 +104,7 @@ public class NonexistentClassSerializersTest extends
ForyTestBase {
.withClassLoader(classLoader)
.build();
Object o = fory2.deserialize(bytes);
- assertTrue(o instanceof NonexistentClass, "Unexpect type " +
o.getClass());
+ assertTrue(o instanceof NonexistentClass, "Unexpected type " +
o.getClass());
}
}
diff --git
a/java/fory-core/src/test/java/org/apache/fory/serializer/collection/CollectionSerializersTest.java
b/java/fory-core/src/test/java/org/apache/fory/serializer/collection/CollectionSerializersTest.java
index 78f9acd55..d2fcc0a1a 100644
---
a/java/fory-core/src/test/java/org/apache/fory/serializer/collection/CollectionSerializersTest.java
+++
b/java/fory-core/src/test/java/org/apache/fory/serializer/collection/CollectionSerializersTest.java
@@ -612,7 +612,7 @@ public class CollectionSerializersTest extends ForyTestBase
{
public EnumSet<TestEnum> enumSet2;
public List<String> emptyList1;
public Set<String> emptySet1;
- // TODO add support for common emtpy
+ // TODO add support for common empty
public Set<String> emptySortedSet;
public List<String> singleList1;
public Set<String> singleSet1;
diff --git
a/java/fory-format/src/main/java/org/apache/fory/format/vectorized/ArrowWriter.java
b/java/fory-format/src/main/java/org/apache/fory/format/vectorized/ArrowWriter.java
index b8916831e..18dd572dc 100644
---
a/java/fory-format/src/main/java/org/apache/fory/format/vectorized/ArrowWriter.java
+++
b/java/fory-format/src/main/java/org/apache/fory/format/vectorized/ArrowWriter.java
@@ -48,7 +48,7 @@ import org.apache.fory.format.row.MapData;
import org.apache.fory.format.row.Row;
import org.apache.fory.format.type.DefaultTypeVisitor;
-// Drived from
+// Derived from
//
https://github.com/apache/spark/blob/921fb289f003317d89120faa6937e4abd359195c/sql/catalyst/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala.
/** Converter between fory {@link Row} and arrow {@link ArrowRecordBatch}. */
diff --git a/javascript/benchmark/index.js b/javascript/benchmark/index.js
index fc315bcf2..84d83d4ec 100644
--- a/javascript/benchmark/index.js
+++ b/javascript/benchmark/index.js
@@ -87,7 +87,7 @@ export const data2TypeInfo = (
);
}
- throw new Error(`unkonw data type ${typeof data}`);
+ throw new Error(`unknown data type ${typeof data}`);
};
diff --git a/javascript/packages/fory/lib/gen/any.ts
b/javascript/packages/fory/lib/gen/any.ts
index 4dca11749..6274a7261 100644
--- a/javascript/packages/fory/lib/gen/any.ts
+++ b/javascript/packages/fory/lib/gen/any.ts
@@ -48,7 +48,7 @@ export class AnySerializer {
serializer = this.fory.classResolver.getSerializerById(typeId);
}
if (!serializer) {
- throw new Error(`cant find implements of typeId: ${typeId}`);
+ throw new Error(`can't find implements of typeId: ${typeId}`);
}
return serializer;
}
diff --git a/javascript/packages/fory/lib/gen/collection.ts
b/javascript/packages/fory/lib/gen/collection.ts
index 8c809f408..28b2537d4 100644
--- a/javascript/packages/fory/lib/gen/collection.ts
+++ b/javascript/packages/fory/lib/gen/collection.ts
@@ -236,7 +236,7 @@ export abstract class CollectionSerializerGenerator extends
BaseSerializerGenera
// If track elements ref, use first bit 0b1 of header to flag it.
// If collection has null, use second bit 0b10 of header to flag it. If
ref tracking is enabled for this element type, this flag is invalid.
// If collection element types is not declared type, use 3rd bit 0b100 of
header to flag it.
- // If collection element types different, use 4rd bit 0b1000 of header to
flag it.
+ // If collection element types different, use 4th bit 0b1000 of header to
flag it.
return `
const ${flags} = ${this.builder.reader.uint8()};
${this.builder.reader.skip(2)};
diff --git a/javascript/test/fory.test.ts b/javascript/test/fory.test.ts
index 857dfa64c..3e9d04486 100644
--- a/javascript/test/fory.test.ts
+++ b/javascript/test/fory.test.ts
@@ -22,20 +22,20 @@ import { describe, expect, test } from '@jest/globals';
import { fromUint8Array } from '../packages/fory/lib/platformBuffer';
import { MAGIC_NUMBER } from '../packages/fory/lib/type';
-const hight = MAGIC_NUMBER >> 8;
+const high = MAGIC_NUMBER >> 8;
const low = MAGIC_NUMBER & 0xff;
describe('fory', () => {
test('should deserialize null work', () => {
const fory = new Fory();
- expect(fory.deserialize(new Uint8Array([low, hight, 1]))).toBe(null)
+ expect(fory.deserialize(new Uint8Array([low, high, 1]))).toBe(null)
});
test('should deserialize big endian work', () => {
const fory = new Fory();
try {
- fory.deserialize(new Uint8Array([low, hight, 0]))
+ fory.deserialize(new Uint8Array([low, high, 0]))
throw new Error('unreachable code')
} catch (error) {
expect(error.message).toBe('big endian is not supported now');
@@ -45,7 +45,7 @@ describe('fory', () => {
test('should deserialize xlang disable work', () => {
const fory = new Fory();
try {
- fory.deserialize(new Uint8Array([low, hight, 2]))
+ fory.deserialize(new Uint8Array([low, high, 2]))
throw new Error('unreachable code')
} catch (error) {
expect(error.message).toBe('support crosslanguage mode only');
@@ -55,7 +55,7 @@ describe('fory', () => {
test('should deserialize xlang disable work', () => {
const fory = new Fory();
try {
- fory.deserialize(new Uint8Array([low, hight, 14]))
+ fory.deserialize(new Uint8Array([low, high, 14]))
throw new Error('unreachable code')
} catch (error) {
expect(error.message).toBe('outofband mode is not supported now');
diff --git a/javascript/test/typemeta.test.ts b/javascript/test/typemeta.test.ts
index 01851daed..7baa9529c 100644
--- a/javascript/test/typemeta.test.ts
+++ b/javascript/test/typemeta.test.ts
@@ -23,7 +23,7 @@ import * as beautify from 'js-beautify';
describe('typemeta', () => {
- test('should evoluation scheme work', () => {
+ test('should evaluation scheme work', () => {
const fory = new Fory({
mode: Mode.Compatible
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
