This is an automated email from the ASF dual-hosted git repository.
chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fory.git
The following commit(s) were added to refs/heads/main by this push:
new f4188e8bd chore: translate comments (#2442)
f4188e8bd is described below
commit f4188e8bd54919a1318f27c37e54f38f99d83485
Author: co63oc <[email protected]>
AuthorDate: Thu Aug 7 15:41:06 2025 +0800
chore: translate comments (#2442)
<!--
**Thanks for contributing to Fory.**
**If this is your first time opening a PR on fory, you can refer to
[CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).**
Contribution Checklist
- The **Apache Fory** community has requirements on the naming of pr
titles. You can also find instructions in
[CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).
- Fory has a strong focus on performance. If the PR you submit will have
an impact on performance, please benchmark it first and provide the
benchmark result here.
-->
## What does this PR do?
chore: translate comments
<!-- Describe the purpose of this PR. -->
## Related issues
<!--
Is there any related issue? Please attach here.
- #xxxx0
- #xxxx1
- #xxxx2
-->
## Does this PR introduce any user-facing change?
<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/fory/issues/new/choose) describing the
need to do so and update the document if necessary.
-->
- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?
## Benchmark
<!--
When the PR has an impact on performance (if you don't know whether the
PR will have an impact on performance, you can submit the PR first, and
if it will have impact on performance, the code reviewer will explain
it), be sure to attach a benchmark data here.
-->
---
dart/packages/fory-test/lib/util/test_process_util.dart | 16 ++++++++--------
.../analyze/impl/annotation/key_annotation_analyzer.dart | 2 +-
dart/packages/fory/lib/src/memory/byte_reader_impl.dart | 2 +-
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/dart/packages/fory-test/lib/util/test_process_util.dart
b/dart/packages/fory-test/lib/util/test_process_util.dart
index 4fc605450..7b7cfd2c0 100644
--- a/dart/packages/fory-test/lib/util/test_process_util.dart
+++ b/dart/packages/fory-test/lib/util/test_process_util.dart
@@ -19,20 +19,20 @@
import 'dart:io';
-/// 执行命令行命令
+/// Execute command-line command
///
-/// [command] 要执行的命令列表
-/// [waitTimeoutSeconds] 等待命令执行完成的超时时间（秒）
-/// [env] 环境变量
+/// [command] List of commands to be executed
+/// [waitTimeoutSeconds] Timeout duration (in seconds) for waiting for command
execution to complete
+/// [env] Environment variable
///
-/// 返回命令执行是否成功（退出码为0）
+/// Returns whether command execution succeeded (exit code 0)
///
class TestProcessUtil {
- /// 同步执行命令行命令
+ /// Execute command-line command synchronously
static bool executeCommandSync(List<String> command, int timeoutSec,
Map<String, String> env) {
try {
print('Executing command synchronously: ${command.join(' ')}');
- // 使用同步API执行命令
+ // Execute using synchronous API
ProcessResult result = Process.runSync(
command.first,
command.skip(1).toList(),
@@ -40,7 +40,7 @@ class TestProcessUtil {
runInShell: true,
);
- // 输出结果
+ // Output result
stdout.write(result.stdout);
stderr.write(result.stderr);
print("exitCode: ${result.exitCode}");
diff --git
a/dart/packages/fory/lib/src/codegen/analyze/impl/annotation/key_annotation_analyzer.dart
b/dart/packages/fory/lib/src/codegen/analyze/impl/annotation/key_annotation_analyzer.dart
index 4f4a0e3a9..3e5c3344f 100644
---
a/dart/packages/fory/lib/src/codegen/analyze/impl/annotation/key_annotation_analyzer.dart
+++
b/dart/packages/fory/lib/src/codegen/analyze/impl/annotation/key_annotation_analyzer.dart
@@ -51,7 +51,7 @@ class KeyAnnotationAnalyzer {
);
}
getMeta = true;
- // 目前只处理ForyKey
+ // Currently only handles ForyKey
}
}
// If there is no annotation, both includeFromFory and includeToFory
default to true.
diff --git a/dart/packages/fory/lib/src/memory/byte_reader_impl.dart
b/dart/packages/fory/lib/src/memory/byte_reader_impl.dart
index f0f51b1fc..ffa4d928b 100644
--- a/dart/packages/fory/lib/src/memory/byte_reader_impl.dart
+++ b/dart/packages/fory/lib/src/memory/byte_reader_impl.dart
@@ -422,7 +422,7 @@ final class ByteReaderImpl extends ByteReader{
if (_length - _offset < 5){
return _readVarUint36Slow() & 0xffffffff;
}
- int forByteVal = _bd.getUint32(_offset, endian); // 保持高32位为0
+ int forByteVal = _bd.getUint32(_offset, endian); // Keep the high 32 bits
as 0
++_offset;
int val = forByteVal & 0x7F;
if ((forByteVal & 0x80) != 0){
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
