This is an automated email from the ASF dual-hosted git repository.

chaokunyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/fory.git


The following commit(s) were added to refs/heads/main by this push:
     new 68b9f08ea fix(python): fix py release on macos 13 (#2478)
68b9f08ea is described below

commit 68b9f08ea070725ad6f5c56566616e5627d8d23d
Author: Shawn Yang <[email protected]>
AuthorDate: Fri Aug 15 16:46:05 2025 +0800

    fix(python): fix py release on macos 13 (#2478)
    
    <!--
    **Thanks for contributing to Fory.**
    
    **If this is your first time opening a PR on fory, you can refer to
    
[CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).**
    
    Contribution Checklist
    
    - The **Apache Fory** community has requirements on the naming of pr
    titles. You can also find instructions in
    [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).
    
    - Fory has a strong focus on performance. If the PR you submit will have
    an impact on performance, please benchmark it first and provide the
    benchmark result here.
    -->
    
    ## What does this PR do?
    
    <!-- Describe the purpose of this PR. -->
    
    ## Related issues
    #2474
    #2473
    <!--
    Is there any related issue? Please attach here.
    
    - #xxxx0
    - #xxxx1
    - #xxxx2
    -->
    
    ## Does this PR introduce any user-facing change?
    
    <!--
    If any user-facing interface changes, please [open an
    issue](https://github.com/apache/fory/issues/new/choose) describing the
    need to do so and update the document if necessary.
    -->
    
    - [ ] Does this PR introduce any public API change?
    - [ ] Does this PR introduce any binary protocol compatibility change?
    
    ## Benchmark
    
    <!--
    When the PR has an impact on performance (if you don't know whether the
    PR will have an impact on performance, you can submit the PR first, and
    if it will have impact on performance, the code reviewer will explain
    it), be sure to attach a benchmark data here.
    -->
---
 .github/workflows/release.yaml |  1 +
 ci/deploy.sh                   | 31 ++++++++++++++-----------------
 python/pyproject.toml          |  2 +-
 3 files changed, 16 insertions(+), 18 deletions(-)

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
index 919d326fa..0d3728421 100644
--- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -125,6 +125,7 @@ jobs:
         with:
           repository-url: https://test.pypi.org/legacy/
           skip-existing: true
+          verbose: true
           verify-metadata: false
           packages-dir: downloaded_wheels
       - name: Publish to PyPI
diff --git a/ci/deploy.sh b/ci/deploy.sh
index 7de5af5a3..9a71fceb9 100755
--- a/ci/deploy.sh
+++ b/ci/deploy.sh
@@ -72,7 +72,19 @@ build_pyfory() {
   # Fix strange installed deps not found
   pip install setuptools -U
 
-  python setup.py bdist_wheel --dist-dir=../dist
+  if [[ "$OSTYPE" == "darwin"* ]]; then
+    MACOS_VERSION=$(sw_vers -productVersion | cut -d. -f1-2)
+    echo "MACOS_VERSION: $MACOS_VERSION"
+    if [[ "$MACOS_VERSION" == "13"* ]]; then
+      export MACOSX_DEPLOYMENT_TARGET=10.13
+      python setup.py bdist_wheel --plat-name macosx_10_13_x86_64 
--dist-dir=../dist
+    else
+      python setup.py bdist_wheel --dist-dir=../dist
+    fi
+  else
+    python setup.py bdist_wheel --dist-dir=../dist
+  fi
+
   ls -l ../dist
 
   if [ -n "$PLAT" ]; then
@@ -83,22 +95,7 @@ build_pyfory() {
     auditwheel repair ../dist/pyfory-*-linux_*.whl --plat "$PLAT" --exclude 
'*arrow*' --exclude '*parquet*' --exclude '*numpy*' -w ../dist/
     rm ../dist/pyfory-*-linux_*.whl
   elif [[ "$OSTYPE" == "darwin"* ]]; then
-    # Check macOS version
-    MACOS_VERSION=$(sw_vers -productVersion | cut -d. -f1-2)
-    if [[ "$MACOS_VERSION" == "13"* ]]; then
-      # Check if wheel ends with x86_64.whl
-      for wheel in ../dist/pyfory-*-macosx*.whl; do
-        if [[ "$wheel" == *"x86_64.whl" ]]; then
-          echo "Fixing wheel tags for x86_64 wheel: $wheel"
-          wheel tags --platform-tag macosx_12_0_x86_64 "$wheel"
-        else
-          echo "Skipping wheel tags for non-x86_64 wheel: $wheel"
-        fi
-      done
-    else
-      # Other macOS versions: skip wheel repair
-      echo "Skipping wheel repair for macOS $MACOS_VERSION"
-    fi
+    echo "Skip macos wheel repair"
   elif [[ "$OSTYPE" == "msys" || "$OSTYPE" == "win32" ]]; then
     echo "Skip windows wheel repair"
   fi
diff --git a/python/pyproject.toml b/python/pyproject.toml
index a18aa7b61..58b81674e 100644
--- a/python/pyproject.toml
+++ b/python/pyproject.toml
@@ -59,7 +59,7 @@ all = ["pyarrow"]
 dev = ["ruff"]
 
 [tool.setuptools]
-packages = ["pyfory", "pyfory.format", "pyfory.lib", "pyfory.meta"]
+packages = ["pyfory", "pyfory.format", "pyfory.lib", "pyfory.lib.mmh3", 
"pyfory.meta"]
 include-package-data = true
 zip-safe = false
 


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to