urlyy commented on code in PR #2492:
URL: https://github.com/apache/fory/pull/2492#discussion_r2297985805
##########
rust/fory-core/src/types.rs:
##########
@@ -40,27 +40,50 @@ pub enum RefFlag {
}
#[derive(Clone, Copy, Debug, PartialEq, TryFromPrimitive, IntoPrimitive)]
+#[allow(non_camel_case_types)]
#[repr(i16)]
pub enum FieldType {
Review Comment:
However there is already somewhere use `use std::any::TypeId;`, and I don't
know why use it.
##########
rust/fory-core/src/types.rs:
##########
@@ -40,27 +40,50 @@ pub enum RefFlag {
}
#[derive(Clone, Copy, Debug, PartialEq, TryFromPrimitive, IntoPrimitive)]
+#[allow(non_camel_case_types)]
#[repr(i16)]
pub enum FieldType {
Review Comment:
> However there is already somewhere use `use std::any::TypeId;`, and I
don't know why use it.
I mean I dont know the necessity to keep using std::any::TypeId. But if we
choose to use TypeID, then there is no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
