The GitHub Actions job "Fory CI" on fory.git/main has succeeded. Run started by GitHub user pandalee99 (triggered by pandalee99).
Head commit for run: 190d233e2b106bf41392e13b424e1d392cac3683 / Zhong Junjie <[email protected]> refactor(go): rename FieldInfo to FieldDef to avoide name collision (#2594) <!-- **Thanks for contributing to Apache Fory™.** **If this is your first time opening a PR on fory, you can refer to [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).** Contribution Checklist - The **Apache Fory™** community has requirements on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md). - Apache Fory™ has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here. --> ## Why? Previous PR #2554 introduced a type named "FieldInfo", which conflicts with the existing "fieldInfo" in struct.go. This naming collision creates confusion, particularly when interacting with both types. This PR has been split out from the original for easier review. <!-- Describe the purpose of this PR. --> ## What does this PR do? <!-- Describe the details of this PR. --> rename FieldInfo to FieldDef to avoide name collision ## Related issues <!-- Is there any related issue? If this PR closes them you say say fix/closes: - #xxxx0 - #xxxx1 - Fixes #xxxx2 --> #2192 ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/fory/issues/new/choose) describing the need to do so and update the document if necessary. Delete section if not applicable. --> - [ x ] Does this PR introduce any public API change? no. - [ x ] Does this PR introduce any binary protocol compatibility change? no. ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. Delete section if not applicable. --> Report URL: https://github.com/apache/fory/actions/runs/17585450307 With regards, GitHub Actions via GitBox --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
