esafak commented on code in PR #2605:
URL: https://github.com/apache/fory/pull/2605#discussion_r2341927347


##########
java/fory-core/src/main/java/org/apache/fory/BaseFory.java:
##########
@@ -222,4 +223,7 @@ public interface BaseFory {
 
   /** Deep copy the <code>obj</code>. */
   <T> T copy(T obj);
+
+  /** Return the class resolver used by this fory instance. */
+  ClassResolver getClassResolver();

Review Comment:
   When you said
   > You can invoke fory.getClassResolver().register(String) method for 
registration. Maybe we should expose this API to BaseFory class too
   What did you mean, then?



##########
java/fory-core/src/main/java/org/apache/fory/BaseFory.java:
##########
@@ -222,4 +223,7 @@ public interface BaseFory {
 
   /** Deep copy the <code>obj</code>. */
   <T> T copy(T obj);
+
+  /** Return the class resolver used by this fory instance. */
+  ClassResolver getClassResolver();

Review Comment:
   When you said
   > You can invoke fory.getClassResolver().register(String) method for 
registration. Maybe we should expose this API to BaseFory class too.
   
   What did you mean, then?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to