HeTPort commented on issue #2285:
URL: https://github.com/apache/fory/issues/2285#issuecomment-3289499430
hi@chaokunyang
While handling this issue, I found that the bazel file seems not to be
complete enough. And upgrading gRPC is necessary but not sufficient.
There are a few possible ways:
1) Enable bzlmod (update Bazel to a version with bzlmod) and keep WORKSPACE
temporarily.
2) Create **MODULE.bazel** and bring core deps in via bzlmod
3) Handle Python toolchain and Cython macro:
Keep using **WORKSPACE** for **python_configure** and **pyarrow_configure**
during the first stage of migration .
Or vendor the Cython macro: copy **cython_library.bzl** into **bazel/** with
**cc_kwargs** support and change:
**load("@com_github_grpc_grpc//bazel:cython_library.bzl", "pyx_library") to
load("@fory//bazel:cython_library.bzl", "pyx_library")**
4) Convert **python_configure** and **pyarrow_configure** to module
extensions. Remove **WORKSPACE** when all repos come from modules/extensions.
From a long-term perspective, which way matches best, or are there any
problems with these solutions?
Would appreciate some guidance—thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
