ThisingL opened a new pull request, #2619: URL: https://github.com/apache/fory/pull/2619
<!-- **Thanks for contributing to Apache Fory™.** **If this is your first time opening a PR on fory, you can refer to [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).** Contribution Checklist - The **Apache Fory™** community has requirements on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md). - Apache Fory™ has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here. --> ## Why? My previous PR #2615 had an incomplete implementation that was exposed by the recent metashare changes. The factory-based registration only registered serializers to `typeToSerializers` map but didn't create complete `TypeInfo` objects with metadata (`PkgPathBytes`, `NameBytes`, etc.). This latent bug was exposed when metashare code path changes made `WriteMetaStringBytes()` calls mandatory, resulting in nil pointer dereference. And CI **didn't run** `go test -v` in the `tests/` directory, so the codegen tests that would have caught this issue were not executed <!-- Describe the purpose of this PR. --> ## What does this PR do? **1. Complete the factory-based registration** **Before (Incomplete):** ```go // Only registered serializers, missing TypeInfo creation for type_, factory := range factories { serializer := factory() r.typeToSerializers[type_] = serializer // ❌ Only serializer, no TypeInfo } ``` **After (Complete):** ```go for type_, factory := range generatedSerializerFactories.factories { serializer := factory() // ✅ Use complete registration (creates full TypeInfo) pkgPath := type_.PkgPath() typeName := type_.Name() _, err := r.registerType(type_, int32(serializer.TypeId()), pkgPath, typeName, serializer, true) // ✅ Handle pointer type caching for runtime compatibility ptrType := reflect.PtrTo(type_) r.typeToSerializers[ptrType] = serializer if typeInfo, exists := r.typesInfo[type_]; exists { ptrTypeInfo := TypeInfo{ Type: ptrType, TypeID: -typeInfo.TypeID, Serializer: serializer, PkgPathBytes: typeInfo.PkgPathBytes, // ✅ Reuse complete metadata NameBytes: typeInfo.NameBytes, IsDynamic: true, hashValue: calcTypeHash(ptrType), } r.typesInfo[ptrType] = ptrTypeInfo } } ``` **2. Add CI test coverage for the `tests/` directory** to ensure codegen tests are always run ## Related issues - #2227 <!-- Is there any related issue? If this PR closes them you say say fix/closes: - #xxxx0 - #xxxx1 - Fixes #xxxx2 --> ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/fory/issues/new/choose) describing the need to do so and update the document if necessary. Delete section if not applicable. --> - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. Delete section if not applicable. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
