swj20010308 opened a new pull request, #2692: URL: https://github.com/apache/fory/pull/2692
## What does this PR do? `LazyMapTest#testMap` assumes that `HashMap` maintains constant ordering, which can lead to non-deterministic failures if the ordering of `map` when calling `toString()` is different from the ordering of `map` when initializing `LazyMap`. > This class makes no guarantees as to the order of the map; in particular, it does not guarantee that the order will remain constant over time. We can reproduce the non-deterministic failures with [NonDex](https://github.com/TestingResearchIllinois/NonDex): ``` mvn -pl fory-core edu.illinois:nondex-maven-plugin:2.1.7:nondex -Dtest=org.apache.fory.collection.LazyMapTest#testMap ``` Instead of `HashMap`, use `LinkedHashMap` to gurrantee constant ordering over time. ## Does this PR introduce any user-facing change? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
