chaokunyang commented on code in PR #2696:
URL: https://github.com/apache/fory/pull/2696#discussion_r2401478260
##########
go/fory/fory.go:
##########
@@ -174,8 +174,19 @@ type Fory struct {
metaContext *MetaContext
}
-func (f *Fory) RegisterTagType(tag string, v interface{}) error {
- return f.typeResolver.RegisterTypeTag(reflect.ValueOf(v), tag)
+func (f *Fory) RegisterType(
+ v interface{},
+ namespace string,
+ typeName string,
+) error {
+ return f.typeResolver.RegisterNamedType(reflect.TypeOf(v), namespace,
typeName)
+}
+
+func (f *Fory) Register(
Review Comment:
Maybe register API should be register by ID, and we have a func
`RegisterNamedType` which register by name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
