chaokunyang commented on code in PR #2765:
URL: https://github.com/apache/fory/pull/2765#discussion_r2428476587
##########
rust/fory-core/src/buffer.rs:
##########
@@ -79,82 +81,82 @@ impl Writer {
}
#[inline(always)]
- pub fn write_u8(&mut self, value: u8) {
- self.bf.write_u8(value).unwrap();
+ pub fn write_u8(&mut self, value: u8) -> Result<(), Error> {
+ Ok(self.bf.write_u8(value)?)
}
#[inline(always)]
- pub fn write_i8(&mut self, value: i8) {
- self.bf.write_i8(value).unwrap();
+ pub fn write_i8(&mut self, value: i8) -> Result<(), Error> {
+ Ok(self.bf.write_i8(value)?)
}
#[inline(always)]
- pub fn write_u16(&mut self, value: u16) {
- self.bf.write_u16::<LittleEndian>(value).unwrap();
+ pub fn write_u16(&mut self, value: u16) -> Result<(), Error> {
+ Ok(self.bf.write_u16::<LittleEndian>(value)?)
}
#[inline(always)]
- pub fn write_i16(&mut self, value: i16) {
- self.bf.write_i16::<LittleEndian>(value).unwrap();
+ pub fn write_i16(&mut self, value: i16) -> Result<(), Error> {
+ Ok(self.bf.write_i16::<LittleEndian>(value)?)
}
#[inline(always)]
- pub fn write_u32(&mut self, value: u32) {
- self.bf.write_u32::<LittleEndian>(value).unwrap();
+ pub fn write_u32(&mut self, value: u32) -> Result<(), Error> {
+ Ok(self.bf.write_u32::<LittleEndian>(value)?)
Review Comment:
It's unnecessary to return Result for wirte, we can always ensure right will
never go wrong
##########
rust/fory-core/src/buffer.rs:
##########
@@ -79,82 +81,82 @@ impl Writer {
}
#[inline(always)]
- pub fn write_u8(&mut self, value: u8) {
- self.bf.write_u8(value).unwrap();
+ pub fn write_u8(&mut self, value: u8) -> Result<(), Error> {
+ Ok(self.bf.write_u8(value)?)
}
#[inline(always)]
- pub fn write_i8(&mut self, value: i8) {
- self.bf.write_i8(value).unwrap();
+ pub fn write_i8(&mut self, value: i8) -> Result<(), Error> {
+ Ok(self.bf.write_i8(value)?)
}
#[inline(always)]
- pub fn write_u16(&mut self, value: u16) {
- self.bf.write_u16::<LittleEndian>(value).unwrap();
+ pub fn write_u16(&mut self, value: u16) -> Result<(), Error> {
+ Ok(self.bf.write_u16::<LittleEndian>(value)?)
}
#[inline(always)]
- pub fn write_i16(&mut self, value: i16) {
- self.bf.write_i16::<LittleEndian>(value).unwrap();
+ pub fn write_i16(&mut self, value: i16) -> Result<(), Error> {
+ Ok(self.bf.write_i16::<LittleEndian>(value)?)
}
#[inline(always)]
- pub fn write_u32(&mut self, value: u32) {
- self.bf.write_u32::<LittleEndian>(value).unwrap();
+ pub fn write_u32(&mut self, value: u32) -> Result<(), Error> {
+ Ok(self.bf.write_u32::<LittleEndian>(value)?)
Review Comment:
It's unnecessary to return Result for write, we can always ensure right will
never go wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
