chaokunyang commented on code in PR #2712:
URL: https://github.com/apache/fory/pull/2712#discussion_r2412366228
##########
rust/fory-core/src/serializer/enum_.rs:
##########
@@ -59,13 +59,19 @@ pub fn write_type_info<T: Serializer>(context: &mut
WriteContext, is_field: bool
let meta_index = context.push_meta(rs_type_id) as u32;
context.writer.write_varuint32(meta_index);
} else {
- let resolver = context.get_fory().get_type_resolver();
- let type_info = resolver.get_type_info(rs_type_id);
- let _namespace = type_info.get_namespace().to_owned();
- let _type_name = type_info.get_type_name().to_owned();
- unimplemented!("unimplement NamedEnum::write_type_info when
non-share_meta")
- // context.writer.write_bytes(namespace.bytes.as_slice());
- // context.writer.write_bytes(type_name.bytes.as_slice());
+ let type_info = context
+ .get_fory()
+ .get_type_resolver()
+ .get_type_info(rs_type_id);
+ let namespace = type_info.get_namespace().to_owned();
+ let type_name = type_info.get_type_name().to_owned();
+ let resolver = context.get_fory().get_metastring_resolver();
Review Comment:
could we submit a new pr to split `metastring_resolver` into
`metastring_write_resolver` and `metastring_read_resolver`, then put it into
`ReadContext`/`WriteContext`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
