chaokunyang commented on code in PR #2702:
URL: https://github.com/apache/fory/pull/2702#discussion_r2407276815


##########
java/fory-core/src/main/java/org/apache/fory/resolver/ClassInfoSerializer.java:
##########
@@ -0,0 +1,21 @@
+package org.apache.fory.resolver;
+
+import org.apache.fory.memory.MemoryBuffer;
+
+/**
+ * ClassInfoSerializer provides a mechanism to customize the recording of the 
ClassInfo
+ * default implementation uses a short value, however when the class 
registration needs to be customized
+ * this can be set of the ClassResolver to handle storing the ClassInfo is a 
customized manner
+ */
+public interface ClassInfoSerializer {

Review Comment:
   This will introduce another indirection, and incur virtual method call. The 
performance will degrade. Could you share some detais what will you implement 
using this ClassInfoSerializer. Maybe we could just merge the funtions of 
subclass of ClassInfoSerializer into class resolver



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to