urlyy commented on PR #2812: URL: https://github.com/apache/fory/pull/2812#issuecomment-3434864111
> > Is this ok with you? And there exists a `TypeResolver::type_info_map_by_ms_name: HashMap<...>`, should I rename it to `type_info_map_by_meta_string_name`? > > > > please rename them too, don't use abbr unless it's commonly used in the industry ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
