urlyy commented on PR #2815: URL: https://github.com/apache/fory/pull/2815#issuecomment-3435934416
> @chaokunyang 我准备把SharedResolver拆开，这样就没引入新的结构体了。目前test_register.rs和test_multi_thread.rs都能通过测试。其他的测试需要把new_from_fory做unwrap()才能执行成功 @chaokunyang @theweipeng 貌似要unsafe impl必须要有一个Wrapper结构体，SharedResolver好像是必需的。麻烦你们review下还有没有其他的问题，如果没问题我就把ut的new_from_fory调用全部加上unwrap，还挺多的。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
