chaokunyang commented on code in PR #2852:
URL: https://github.com/apache/fory/pull/2852#discussion_r2480619864


##########
java/fory-core/src/main/java/org/apache/fory/ThreadLocalFory.java:
##########
@@ -59,7 +60,9 @@ public ThreadLocalFory(Function<ClassLoader, Fory> 
foryFactory) {
         ThreadLocal.withInitial(
             () -> {
               LoaderBinding binding = new LoaderBinding(foryFactory);
-              binding.setBindingCallback(factoryCallback);
+              synchronized (callbackLock) {

Review Comment:
   why we need this, this seems fix nothing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to