chaokunyang commented on code in PR #2888:
URL: https://github.com/apache/fory/pull/2888#discussion_r2488480789
##########
.github/workflows/ci.yml:
##########
@@ -65,6 +65,30 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: 3.8
+ - name: Cache Bazel binary
+ uses: actions/cache@v4
+ with:
+ path: |
+ ~/bin/bazel
+ ~/.local/bin/bazel
+ key: bazel-binary-${{ runner.os }}-${{ runner.arch }}-${{
hashFiles('.bazelversion') }}
+ restore-keys: |
+ bazel-binary-${{ runner.os }}-${{ runner.arch }}-
+ - name: Cache Bazel repository cache
+ uses: actions/cache@v4
+ with:
+ path: ~/.cache/bazel/_bazel_*/*/external
+ key: bazel-repo-${{ runner.os }}-${{ runner.arch }}-${{
hashFiles('WORKSPACE', '.bazelrc', 'bazel/**') }}
+ restore-keys: |
+ bazel-repo-${{ runner.os }}-${{ runner.arch }}-
+ - name: Cache Bazel build outputs
+ uses: actions/cache@v4
+ with:
+ path: ~/.cache/bazel
+ key: bazel-build-java-${{ runner.os }}-${{ runner.arch }}-${{
matrix.java-version }}-${{ hashFiles('cpp/**', 'python/**/*.pyx', 'BUILD',
'WORKSPACE') }}
Review Comment:
could we also add `python/**/*.pyd? it can also define inline header only
functions
##########
.github/workflows/ci.yml:
##########
@@ -65,6 +65,30 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: 3.8
+ - name: Cache Bazel binary
+ uses: actions/cache@v4
+ with:
+ path: |
+ ~/bin/bazel
+ ~/.local/bin/bazel
+ key: bazel-binary-${{ runner.os }}-${{ runner.arch }}-${{
hashFiles('.bazelversion') }}
+ restore-keys: |
+ bazel-binary-${{ runner.os }}-${{ runner.arch }}-
+ - name: Cache Bazel repository cache
+ uses: actions/cache@v4
+ with:
+ path: ~/.cache/bazel/_bazel_*/*/external
+ key: bazel-repo-${{ runner.os }}-${{ runner.arch }}-${{
hashFiles('WORKSPACE', '.bazelrc', 'bazel/**') }}
+ restore-keys: |
+ bazel-repo-${{ runner.os }}-${{ runner.arch }}-
+ - name: Cache Bazel build outputs
+ uses: actions/cache@v4
+ with:
+ path: ~/.cache/bazel
+ key: bazel-build-java-${{ runner.os }}-${{ runner.arch }}-${{
matrix.java-version }}-${{ hashFiles('cpp/**', 'python/**/*.pyx', 'BUILD',
'WORKSPACE') }}
Review Comment:
could we also add `python/**/*.pyd`? it can also define inline header only
functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
